search

overture-stack / stage

GNU Affero General Public License v3.0
0 stars 4 forks source link

Pass Correct URL to Table Component for TSV Download #55

Closed gokul472 closed 3 years ago

gokul472 commented 4 years ago

The TSV download for the explorer table currently isn't working, it is trying to access the localhost instead of the server URL specified in the Arranger API's configuration

Currently, clicking the button does nothing - Once the URL is corrected, the file should download

gokul472 commented 4 years ago

TSV download feature is already implemented. 1) Individual download of files is Nice to have. 2) Feature- Download manifest file - Nice to have.

b-f-chan commented 3 years ago

TSV already works, removed original ticket description. This will now be a bug fix to pass the correct URL so the download initiates.

anncatton commented 3 years ago

Investigated this with @joneubank. The downloadUrl can be set specifically on the Table component to ensure the right domain is being accessed, but once this is corrected we get an error response from the arranger server: (0 , _apolloServerCore.runQuery) is not a function Seems to be a problem with the version of apollo-server-core library Arranger is using. We did try pinning all versions (including sub-dependencies) to 2.14.2 but this led to further mismatched dependency version issues. I will make a small pr for the url change but looks like this will require further investigation in Arranger itself.

b-f-chan commented 3 years ago

Blocked by arranger#644

b-f-chan commented 3 years ago

Actual download behaviour can't be tested until arranger#644 fixed

Scope to test for this ticket is that the download URL is no longer localhost

Tested on staging, in browser console, request is correctly going to the actual download endpoint: