search

overture-stack / website

Overture.bio website, based on Gatsby static site generator
GNU Affero General Public License v3.0
1 stars 2 forks source link

Post MVP Mega Ticket #327

Closed daniel-cy-lu closed 11 months ago

daniel-cy-lu commented 11 months ago

check off all requirements in the zenhub ticket.

Please see Mitchell and Patrick's comments and feedback. I checked off everything except for one task which required too much unnecessary work, so we will keep the original work. (To move icons and burger in the navbar, we would need to abandon bulma template and rebuilt a navbar).

MitchellShiell commented 11 months ago

Nice work Daniel!

Primary feedback, mobile versions are loading in zoomed, I can show you can't replicate.

daniel-cy-lu commented 11 months ago

Nice work Daniel!

Primary feedback, mobile versions are loading in zoomed, I can show you can't replicate.

Mitchell, this issue is resolved along with misalignment in some of the pages. :)

daniel-cy-lu commented 11 months ago

@samrichca off the top of your head, do you know how to resolved overflow:auto not working because I wrapped <div> around <img>, and now instead of hiding the part that is overflowing, it resize all the div containing the img to fit the screen?

This is the commit I did: https://github.com/overture-stack/website/pull/327/commits/3c3e9245ed8bf1cebcda28630091aa099238d2e4