search

overview / overview-server

Open source large document set visualization platform
https://www.overviewdocs.com
Other
269 stars 37 forks source link

"Please fill out this field" does not appear on Safari #225

Open jstray opened 11 years ago

jstray commented 11 years ago
  1. Open "Use a query on public DocumentCloud documents (advanced)…"
  2. Enter query but not title
  3. Click "import"

Result:

Expected:

Works fine on Chrome, Firefox

adamhooper commented 11 years ago

This is one of those "spiral out of control" bugs.

We need an HTML5 "shim" library, because Safari 5 and IE9 don't do form validation.

So we need Modernizr, because it's a requirement for lots of shims--including http://afarkas.github.com/webshim/demos/demos/webforms.html which is the only one mentioned by html5please.com which seems to work.

But Modernizr launches AJAX requests for other files, from the client, to add shims for missing features.

But Modernizr doesn't know what the URLs are for the shims, since we generate those URLs during asset compilation.

We need some way of feeding that mapping of (original URL) -> (new URL) back into JavaScript. Then we can load shims, then this bug will be easy to solve.

adamhooper commented 11 years ago

This is still an issue on Safari 6.

Safari is 11% of our traffic; IE9 is 3%; IE <9 is ~3.5%. So this bug affects 14% of users.

adamhooper commented 7 years ago

Safari 10.1 has HTML form validation. We'll want to test this, but it's likely fixed.