UI stops updating import jobs after cancellation

overview / overview-server

Open source large document set visualization platform

https://www.overviewdocs.com

Other

269 stars 37 forks source link

UI stops updating import jobs after cancellation #560

Closed thejonas closed 9 years ago

thejonas commented 11 years ago

In Chrome (unable to reproduce in safari)

Import a document cloud job
Cancel the job during the import stage
Import a new job

Expected: Import progress continues to update Actual: No import job ever updates progress again (reload shows updated status)

No errors in javascript console

adamhooper commented 11 years ago

I cannot reproduce this. I think the bug actually lies elsewhere. Why? Because the page reloads between each step. As written, steps 1 and 2 cannot have any influence on step 3.

That's the theory, and obviously there are ample opportunities for reality to differ from theory. But I can't fathom what that difference might be; and heck, I may have fixed it in the past couple of days as I revamped the docset list.

Marking invalid. If you can still reproduce, please add more details.

thejonas commented 11 years ago

I don't even have to cancel the job anymore, I just import several jobs and eventually the first one stops updating. Now also happening in Safari. I can reproduce it on staging, so maybe try there.

adamhooper commented 11 years ago

I cannot reproduce this. Are you doing this with DocumentCloud docsets? It could be that DocumentCloud is letting you down in a manner that coincides with your page refreshes.

Other question: open up the network console. Are the requests being sent every second as they should be?

adamhooper commented 11 years ago

Other question: when's the last time you restarted Chrome? Have you perhaps done system updates and then not restarted Chrome after they've completed?

adamhooper commented 11 years ago

s/Chrome/Safari...

thejonas commented 11 years ago

Still seeing this in Chrome after rebooting machine and restarting Chrome. Unable to reproduce in Firefox.

After importing a bunch of jobs, the requests that are supposed to be sent every second no longer show up. Reloading the page (Cmd-R, Cmd-Shift-R) doesn't help. If I open the page in a new tab, the new tab updates properly while the original remains stuck

jstray commented 11 years ago

Saw this yesterday. Chrome, Mac. As follows:

cloned Wikileaks example
progress bar seemed to stall at about 25% complete ("saving document tree")
after 30s or so, cloned MMS set
MMS set showed up in line
Wikileaks set still seemed stalled
After 1m or so, cancelled Wikileaks
It cancelled, and MMS seemed to complete immediately

This seems consistent with the idea that it's a client progress polling bug, and the Wikileaks set did complete but I didn't see it. Note however, no errors in JS console.

adamhooper commented 9 years ago

Old bug cleanup: things are so different now the underlying bug is very likely to still be there :).