search

overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.36k stars 481 forks source link

Add support for halloween update. #142

Closed alexjurkiewicz closed 13 years ago

alexjurkiewicz commented 14 years ago

It looks like:

eminence commented 13 years ago

emirin,

i just took a look at this problem. it seems to be related to the fact that the biome files are not opened in binary mode. i will submit an update that fixes this when i get home. in the meantime, if you want to manually patch your code, make the following change:

Look for the following line in textures.py. It should be near line 580:

 f = open(os.path.join(worlddir, "EXTRACTEDBIOMES", biomeFile))

and add "rb" as the last argument to open. It should now look like:

 f = open(os.path.join(worlddir, "EXTRACTEDBIOMES", biomeFile), "rb")
emirin commented 13 years ago

Looks like its flying, I'll let you know if I run into anything else after it finishes in a few hours. Thanks much!

Luckz commented 13 years ago

(For the record, I just used Paint.NET to copy the old grass colour/pixels into the new PNG to stop my Overviewer map from looking like ass.)

electrofloat commented 13 years ago

Hi,

I've just tried to check out eminence biomes branch. At 1st it says: TypeError: exists() takes exactly 1 argument (2 given)

I fixed this by deleting "rb" at the end, but after that: AttributeError: 'module' object has no attribute 'grasscolor'

any ideas?

electrofloat commented 13 years ago

Hmm.. okay. I think i've managed to get over it by copying foliagecolor.png and grasscolor.png from world/EXTRACTEDBIOMES folder to the minecraftoverviewer/texture folder. Though I think it should not work this way. As i see it tries to find these files from the minecraft.jar which is where it expects ($HOME/.minecraft/bin/minecraft.jar) So I don't exactly know what's going on.

eminence commented 13 years ago

I've just merged in the biome rendering code i've been working on. if the BIOMEEXTRACTOR data is present, it will be used. The bug with exists that mydexterid mentioned has been fixed. Also, a more helpful error message is displayed if grasscolor and foliagecolor.png can't be found.

bjorhn commented 13 years ago

I want to try it out, but I don't have the minecraft client on my server. Is there a way to run biomeextractor without access to the client? Or is there a recommended way of getting this to work? The reason I'd prefer not to put the client on the server is that I'm using a custom texture pack, but I'm hoping someone might have a decent solution. I really want to try out the biome rendering, thanks for merging it with the master branch. :)

eminence commented 13 years ago

as far as i know biome extractor always requires the client (since it uses the class files from minecraft to do the biome calculations). but having the client installed shouldn't affect the use of a custom texture pack (at least not that i can see. am i missing something?)

bjorhn commented 13 years ago

No, I suppose you aren't. For some reason I was under the assumption that files generated by biomeextractor would somehow be based on the terrain textures in minecraft.bin, but now that I think about it, that's a pretty silly assumption. I'll try running this on the server, then, hopefully it will start up despite my lack of a graphics card. Thanks!

eminence commented 13 years ago

on an unrelated note, i would like to close this issue as i think all of the things that alex mentioned up top have now been addressed. plus i don't want to keep spamming everybody on this ticket with updates.

so unless there are objections, i'd like to close this and ask that people open new issues for any problems they're experiencing

bjorhn commented 13 years ago

Close it! On an unrelated note, in case someone is looking at this ticket for advice, the minecraft client will not run on a server without some kind of rendering system. Without running it, it can't download the necessary data that biomeextractor requires, and thus you cannot run biomeextractor. As of yet, I haven't figured out a solution. Maybe asking someone that has a linux client installation of minecraft to send the files over might be the only way.

eminence commented 13 years ago

i was able to successfully get the minecraft client to download the stuff with some X forwarding. The game won't run completely, but you can get to the login screen to have the launcher download the necessary files. send me a message if you have any questions.

[closing this ticket]