search

overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.36k stars 482 forks source link

Feature Request: adjust overall render brightness #1679

Open jhardin-impsec opened 4 years ago

jhardin-impsec commented 4 years ago

I just started using a new resource pack and wanted to render the map using those resources, but the new resources cause the map to render much darker than the default resources.

I took a look at the configs but there's no obvious config option to control the overall brightness of the entire render - Lighting.strength doesn't sound quite appropriate, as the description is "how dark to make the shadows".

So, request: a config setting to control an overall bright/dark adjustment of the render, +n (brighter) or -n (darker), where zero = no adjustment.

knightsofn1 commented 4 years ago

Is this not handled by the rendermodes already?

I've got my End dimension rendering with the following: "rendermode": [Base(), EdgeLines(), SmoothLighting(strength=0.5), Depth(max=130, min=1)],

That strength setting seems like the one you're asking for. Certainly when I was experimenting with values in there it seemed to be controlling the overall brightness.

jhardin-impsec commented 4 years ago

I will try that, thanks.

CounterPillow commented 4 years ago

the strength kind of doesn't quite do what he wants but can get him partway there. Ideally we add another rendermode primitive that can adjust the brightness.

jhardin-impsec commented 4 years ago

It does not. That only adjusts the shadows, not the overall brightness. Non-shadow areas remain dark from the texture pack colors.

FWIW, strength=2.0 is... amusing.

jhardin-impsec commented 4 years ago

Here's an example: mco_overall_brightness_baseline

The resource pack is MYTHIC+-+1.14.zip