overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.36k stars 481 forks source link

Downloaded world rendered, nothing to see #2038

Open lajawi opened 2 years ago

lajawi commented 2 years ago

I downloaded a world, unzipped it, and then tried rendering it but nothing shows up if I open index.html, as seen below. Image I am running version 0.17.47 (7171af5), built on Tue Dec 09:17:20 2021.

vilhok commented 2 years ago

So what does the directory structure look like? Do you have the directory called overworld or whatever you named your map in your config file? What I wonder is that did the map render at all? What browser are you using to view this?

CounterPillow commented 2 years ago

it's probably an issue with the chunk states, I need to look into this if I ever work on overviewer again

lajawi commented 2 years ago

So what does the directory structure look like? Do you have the directory called overworld or whatever you named your map in your config file? What I wonder is that did the map render at all? What browser are you using to view this?

It’s just like you’d expect. The root folder has the different files, one of which is index.html, as well as another folder with all kinds of different images (in my case a black) in different folders with names like 1, 2, 3, & 4.

1nhu commented 2 years ago

So what does the directory structure look like? Do you have the directory called overworld or whatever you named your map in your config file? What I wonder is that did the map render at all? What browser are you using to view this?

It’s just like you’d expect. The root folder has the different files, one of which is index.html, as well as another folder with all kinds of different images (in my case a black) in different folders with names like 1, 2, 3, & 4.

so I do not really see a fix in here... is there a fix even? image

HiltonWS commented 2 years ago

@1nhu What is the Minecraft version?

CounterPillow commented 2 years ago

If you're running 17.47 and this is a 1.18 world then this is likely because the blocks were placed and the lowest point of the world, and your Overviewer version does not support rendering the new depths.

Can't really tell without a link to the world.

1nhu commented 2 years ago

1.18.2

понедельник, 6 июня 2022 г. пользователь Hilton W. Silva < @.***> написал:

@1nhu https://github.com/1nhu What is the Minecraft version?

— Reply to this email directly, view it on GitHub https://github.com/overviewer/Minecraft-Overviewer/issues/2038#issuecomment-1147649817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZIRK3SCIWMNRM33354A6U3VNYSKZANCNFSM5V4KRJEQ . You are receiving this because you were mentioned.Message ID: @.***>

CounterPillow commented 2 years ago

I fixed the builders, try with Overviewer v0.17.63

1nhu commented 2 years ago

will try today, thanks

среда, 8 июня 2022 г. пользователь Nicolas F. @.***> написал:

I fixed the builders, try with Overviewer v0.17.63

— Reply to this email directly, view it on GitHub https://github.com/overviewer/Minecraft-Overviewer/issues/2038#issuecomment-1150060607, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZIRK3SRC5NNCX5ACGVATRDVOC24BANCNFSM5V4KRJEQ . You are receiving this because you were mentioned.Message ID: @.***>

Hraefin commented 2 years ago

Hate to ask, but did you try clearing cache on browser? restart browser?

I have had that happen with Chrome just not behaving.

1nhu commented 2 years ago

well, I am cleaning cache often and I've tried the file multiple times, did it help though? No and no

суббота, 11 июня 2022 г. пользователь David S. @.***> написал:

Hate to ask, but did you try clearing cache on browser? restart browser?

I have had that happen with Chrome just not behaving.

— Reply to this email directly, view it on GitHub https://github.com/overviewer/Minecraft-Overviewer/issues/2038#issuecomment-1152774986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZIRK3XTZNTCYCTZESOSPC3VOO5PPANCNFSM5V4KRJEQ . You are receiving this because you were mentioned.Message ID: @.***>

CounterPillow commented 2 years ago

then please zip up the world and upload it as a sample, or otherwise provide us with a download link

1nhu commented 2 years ago

Yeah, tried the newest version, still nothing, blackness. My zip is 1447mb, where should I upload it, If I should

CounterPillow commented 2 years ago

upload it here: https://overviewer.org/uploader/

cliffmeyers commented 2 years ago

I'm seeing similar behavior with many blank tiles after applying 4e51b216524ccc535893efdaeef48d75061640d4 and running against a subset of my world. see additional discussion in https://github.com/overviewer/Minecraft-Overviewer/issues/2010#issuecomment-1107540828

I extracted a region of my world that had not been visited since we upgraded to 1.18+ (currently on 1.18.1 and I run every upgrade with the --forceUpgrade flag). I have uploaded the world files as test-upload.zip via the uploader tool.

Here is the region in MCA Selector, note that some chunks of the region have never been visited and haven't generated.

MCA_Selector_jf4VNEMCuY

Prior to applying 4e51b216524ccc535893efdaeef48d75061640d4, it would actually throw an exception when trying to render a chunk that hadn't been generated. Eventually the entire render process would completely hang and do nothing after a few hours. I scrolled back and counted 15 exceptions which is equal to the value of processes from my config.py, so I'm assuming each exception was causing each thread/process to hang until the pool was exhausted.

This no longer happens after applying 4e51b216524ccc535893efdaeef48d75061640d4 but I think rather than an exception killing the thread, part of the render is effectively skipped and results in many blank tiles. Based on the behavior of test-world it seems like the entire region might get rendered blank in this particular state of my world files.

I've been looking at chunks [85, -59] which is the top-left chunk in the unvisited area and also [84, -59] (immediately to the left, a generated chunk) for differences but I'm new to NBTs so the learning curve's a bit steep for me right now.

CounterPillow commented 2 years ago

@cliffmeyers I don't see your upload, if it's small enough try attaching it to the issue here.

cliffmeyers commented 2 years ago

@CounterPillow sure, here it is: test-world.zip

cliffmeyers commented 2 years ago

@lajawi you might want to check out the branch from @ralokt in #2051 - I built his branch and ran against my test world and the unvisited chunks are now rendering, and it handles the ungenerated chunks as you expect (empty space)