overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.35k stars 480 forks source link

Some tiles do not get lighting data applied.. #408

Closed KariTrace closed 13 years ago

KariTrace commented 13 years ago

...Tried with both 0.0.6 and with 0.1.4 binaries on Win 7 x64 and Win Server 2k8 x64. Every run completes without errors but some tiles do not have lighting applied correctly. Normal: ok, Light: some times Night: VERY noticeable Spawn: n/a Caves: not so much

The entire "world" folder is copied, overviewer is run, the results are copied into a sub folder inside the htdocs of my web server. For an example: http://ssd.servehttp.com/minecraft/map/

Ideas?

KT

agrif commented 13 years ago

These bright spots at night are caused by incorrect tall grass handling in older versions of Overviewer. Instead of the official release-0.1.4, try using the release-0.1.4-59-g9cdfe0e nightly kit.

Completely Unrelated:

You seem to have incremental update problems (like here). Right now I'm trying to track down a bug that looks just like this, but this can also be caused by improperly copying tiles or worlds back and forth; Overviewer needs the file modification times to be correct. Could you go into greater detail about how your world and tiles are copied during a render? Exact commands would be great, but you can change the paths around if you want.

KariTrace commented 13 years ago

Issue 1) Ah, ok, just a bad texture issue at the moment. That's understandable. Using the nightly builds is, unfortunately a bit beyond y current technical knowledge; being a web developer I don't often have to compile things :). Knowing whats wrong it just as well till a stable release.

Issue 2) That's no problem Processes: 1) Copy world to a backup directory 2) Run overviewer, creating the maps 3) Copy maps to htdocs folder

Keeps the exe's outside the publicly accessible folders.

REM Uncomment the following 4 lines to kill the cache.. xcopy /h /s /e /y "C:---path to server folder---\Server\world" "C:---path to overviewer folder---\overviewer014\world" overviewer.exe --skip-js --processes=1 --rendermode=normal,lighting,night,spawn,cave "world" "maps" xcopy /h /s /e /y "C:---path to overviewer folder---\overviewer014\maps" "C:---path to htdocs folder for minecraft---\map"

This is all in a *.bat file that is executed by the windows task scheduler, events setup for 3 Hrs increments.

Xon commented 13 years ago

xcopy doesn't preserve timestamps. You need to use something else to copy the files and keep timestamps around.

The following robocopy command will do the job;

robocopy /s /e /copy:dat /dcopy:t "C:---path to overviewer folder---\overviewer014\maps" "C:---path to htdocs folder for minecraft---\map"
agrif commented 13 years ago

As Xon noted, xcopy doesn't preserve timestamps. On unix it's as simple as using cp -p instead of cp, but on windows it's a bit more complicated. You'll also want to use a timestamp-preserving copy for the world directory as well.

Also, the nightly builds on the downloads page are pre-built, just like the "stable" releases; the decision to make a "stable" release is really arbitrary so I wouldn't feel that uncomfortable running an "unstable" release instead.

KariTrace commented 13 years ago

So If I understand it correctly; the nightly builds I would run overviewer.py instead of overviewer.exe with the same arguments. Assuming of course python is installed. I would also need a C compiler too, right?

agrif commented 13 years ago

No, no, the nightly builds are exactly the same as the release builds; there's an overviewer.exe and everything. :P

KariTrace commented 13 years ago

Doh, I should really look a little closer next time.. (didnt mean to close this btw). I'll try it out tomorrow and let you know how it goes.

pironic commented 13 years ago

Check your terrain.png? If you have the minecraft.jar on the same machine, this may need updating.

Only one thought.


Sent from my Android Smartphone On 2011-06-16 9:03 PM, "KariTrace" < reply@reply.github.com> wrote:

...Tried with both 0.0.6 and with 0.1.4 binaries on Win 7 x64 and Win Server 2k8 x64. Every run completes without errors but some tiles do not have lighting applied correctly. Normal: ok, Light: some times Night: VERY noticeable Spawn: n/a Caves: not so much

The entire "world" folder is copied, overviewer is run, the results are copied into a sub folder inside the htdocs of my web server. For an example: http://ssd.servehttp.com/minecraft/map/

Ideas?

KT

Reply to this email directly or view it on GitHub: https://github.com/brownan/Minecraft-Overviewer/issues/408

KariTrace commented 13 years ago

Arg...ideas for this error: 18:15:45,460 [WARNING] Error opening chunk (-44, -23) in world\region\r.-2.-1.mcr. It may be corrupt. Unsupported chunk compression type: 38..

This is occurring on the most recent nightly builds, also, the process does not die, has to be manually killed.

I had robocopy re-copy the map and re-run the script, still error'd. Play testing the map itself nothing seems to be out of place...

agrif commented 13 years ago

Looks like one of your region files is corrupt. Compression type should be, at most, 2. So something went wrong somewhere. I'm not sure if this would show up in-game since only one of the types is used, so Minecraft might not even check that field.

Is there some way for you to upload the offending region file somwhere for me to poke at it? If not, feel free to email it to me at aargri@gmail.com.

KariTrace commented 13 years ago

Done, and sent. TY for the quick response...

agrif commented 13 years ago

There's definitely a corrupt chunk in there (r.-2.-1.mcr):

(snip)
(28, 8) [1308416967] 4037 bytes (zlib)
(29, 8) [1308416967] 3821 bytes (zlib)
(30, 8) [1308416967] 4001 bytes (zlib)
(31, 8) [1308416707] 4047 bytes (zlib)
(20, 9) [1308417146] 610598594 bytes (unknown)
(21, 9) [1308417253] 4047 bytes (zlib)
(22, 9) [1308417257] 4047 bytes (zlib)
(23, 9) [1308417539] 2689 bytes (zlib)
(snip)

Notice how (20, 9) is way bigger than the others (it's reported as 610MB, much bigger than the ~1MB file it's inside), and how the compression type is unknown. In your map, this chunk should be near -704, -368 in game. I'd recommend checking it out -- being near the problem might fix it.

If it doesn't get fixed, you can either remove the entire region or surgically remove just that chunk, or you can ignore it. Overviewer should ignore it, too.

Fenixin commented 13 years ago

@KariTrace, You could try region-fixer. It can remove/replace corrupted chunks in region files. You can also use it to delete that chunk. Also, if you want to read and modify region files you can use this NBT library.

KariTrace commented 13 years ago

Sounds reasonable... Using an editor to try and fix the location... Side note: overviewer is not ignoring it unfortunately...

KariTrace commented 13 years ago

Got the regions repaired, looks like there where two of them. Generated: http://ssd.servehttp.com/minecraft/map/ Still got the long grass issue @ night, also noted the cobblestone steps on the Lighting option.

dayres commented 13 years ago

I'm also seeing both the cobblestone step and long grass issue.

-- Using release-0.1.4-89-g6aab671

Fenixin commented 13 years ago

@KariTrace, the cobblestone step and long grass bugs are old overviewer bugs... mmmh... the link you give us (http://ssd.servehttp.com/minecraft/map/) has a lot of old issues, it has the old cactus looking (they are unconnected cactus blocks), the water is rendered in the old way (a water surface per level)... so either you have downloaded an old overviewer or something really wrong is going on here. (or I'm missing something)

@dayres, and something similar is going with your map (taken from issue #412): in night rendermode the water is glowing, the tall grass holes and the black cobblestone stairs.

Can you please check that the version used to render the maps is the last one?

dayres commented 13 years ago

I completely removed everything in the overviewer directory, re-copied the newer release (release-0.1.4-89-g6aab671) and ran the setup.py build again. It appears to be functioning now without the two issues.

Lesson Learned: You cannot update overviewer by copying the files over the old ones and doing a build.

KariTrace commented 13 years ago

Repeated dayres's steps: removed thw world folder used for rendering, delete the maps itself, downloaded recent nightly build re-ran: http://ssd.servehttp.com/minecraft/map/#/104/64/-26/max/mcmapNight location: 103,64,-27

The steps / half blocks are looking better but still not quiet there. Where the half blocks are NOT lighted at night the texturing looks nice, add torch light; not so much.

(and once again I hit comment and close instead of just comment...)

Fenixin commented 13 years ago

@KariTrace, the last windows version doesn't include the fix for the stairs and half-blocks in night rendermode. You can ask for a windows package in the IRC channel (or here) or just wait (windows builds update very often).

eminence commented 13 years ago

I've just uploaded new Windows binaries

KariTrace commented 13 years ago

Results from build win86_64-release-0.1.4-89-g6aab671 http://ssd.servehttp.com/minecraft/map/

Seems to work for the majority, thought a couple ar still blacked out. Good progress though, very impressive.

Fenixin commented 13 years ago

@KariTrace, I can only see one step looking wrong in that map:

http://ssd.servehttp.com/minecraft/map/#/135/64/-44/max/mcmapNight

(I hope we are looking the same map)

All the others look good to me.

I'm not going to have time to look at this in the next week. Please, feel free to open a new issue about the stairs, so we don't forget about it.

(about the problem... maybe the block is in the chunk border?)

KariTrace commented 13 years ago

Will do, closing this (finally). Original issue resolved (and then some).