overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.35k stars 482 forks source link

"The Overviewer is a console program" #542

Closed Cylindric closed 12 years ago

Cylindric commented 12 years ago

Why does this message come up even if I supply all the correct parameters to the programme?

I run from shortcuts, called from other programmes, and from the "Run..." box, so the message makes that all more complicated than it needs to be.

Can this be changed to only come up when no parameters are used? Any numpties running this without know how it works will get the warning, anyone that knows what they're doing can carry on as usual.

Thanks.

brownan commented 12 years ago

It looks like the code @eminence found / came up with doesn't work for all situations. I like your idea of just checking if any arguments were supplied.

@eminence: I suggest taking out that code and putting an "if platform.system() == 'windows': raw_input() inside the existing "if len(sys.args) < 1" block. What do you think?

Cylindric commented 12 years ago

Thanks :) It's not a huge problem for most people, I think if you run it from a batch file or something it should be fine, but I call the executable from an app, so I'll have to do some trickery to get it working. (I tried using a simple cmd /k, but that seemed to cause some other Python problems)

https://github.com/Cylindric/Enigma-MM/blob/master/source/Solution/Server/Engine/Commands/Mappers/Overviewer.cs

tswsl1989 commented 12 years ago

The Windows detection code also prevents our python 3 warning code from running See 2dcf2229

brownan commented 12 years ago

@tswsl1989: that's a separate issue though isn't it? Besides, isn't a python 3 check mostly useless because running it in python 3 will just get a syntax error before any code is even run?

Or was your thought to have the syntax error you get to be the print statement saying that it's not python 3 compatible? In which case, that's really clever!

tswsl1989 commented 12 years ago

Seperate but related - I was under the impression that the python 3 check worked, but I've not checked it.

eminence commented 12 years ago

ok, so it sounds like I didn't consider the use case when someone actually wants to run overviewer without a parent console. I like the idea of bypassing this message (perhaps changing it to a simple warning) if all of the necessary options have been specified. I'll start working on this.

Cylindric commented 12 years ago

Thank you :)

Python still scares me too much to fiddle with it, and getting the whole Python+Numpy+PIL stack going on my x64 Windows machine is proving less than fun.

eminence commented 12 years ago

Cylindric, can I have you try out the code that's in the new console_detection branch? I want to make sure the behavior that I came up with seems reasonable to you. If you would like, I can easily create a binary .exe for the platform of your choice (32-bit or 64-bit), just let me know.

Thanks.

Cylindric commented 12 years ago

Sorry, got distracted with a friend's birthday drinks :) I'll be more than happy to test in the morning, but yes a binary would be awesome as I don't have a python env at home

Maybe its time I did :) On Nov 25, 2011 9:31 PM, "Andrew Chin" < reply@reply.github.com> wrote:

Cylindric, can I have you try out the code that's in the new console_detection branch? I want to make sure the behavior that I came up with seems reasonable to you. If you would like, I can easily create a binary .exe for the platform of your choice (32-bit or 64-bit), just let me know.

Thanks.


Reply to this email directly or view it on GitHub:

https://github.com/overviewer/Minecraft-Overviewer/issues/542#issuecomment-2878280

eminence commented 12 years ago

Ok, here is a 32-bit binary: http://goo.gl/eiJ7X

Here is a 64-bit binary: http://goo.gl/cjxcs

Cylindric commented 12 years ago

That worked great. Thank you for the lightning response :)

Big fan by the way, best mapper I've used. On Nov 26, 2011 6:50 AM, "Andrew Chin" < reply@reply.github.com> wrote:

Ok, here is a 32-bit binary: http://goo.gl/eiJ7X

Here is a 64-bit binary: http://goo.gl/cjxcs


Reply to this email directly or view it on GitHub:

https://github.com/overviewer/Minecraft-Overviewer/issues/542#issuecomment-2880262

brownan commented 12 years ago

Thank you @Cylindric!

When I first saw the bug title, I thought it would be an angry post about how we don't have a GUI for Overviewer. =)

eminence commented 12 years ago

ok great. I've pushed the code for this into master.