search

overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.36k stars 482 forks source link

Problem with rendering snow #563

Closed ghost closed 12 years ago

ghost commented 12 years ago

this telescope is missing a snow block dish on its renders http://epic.mycraft.pl/cr/#/201/64/1066/-2/smooth-lighting

ghost commented 12 years ago

oh, and those elements are snow too and there visible http://epic.mycraft.pl/cr/#/214/64/1056/max/smooth-lighting http://dl.dropbox.com/u/915647/2011-12-18_08.58.05.png

agrif commented 12 years ago

That's very odd. I can't believe we haven't seen this before now somewhere else.

I'm about to dig into the code, but one small clarification would be useful: are these the snow blocks that you make out of 4 snowballs, or are they minecraft's snow "block" that normally cover other other blocks in winter biomes?

We handle the latter specially, but the first one should act just like all other cubes...

ghost commented 12 years ago

snow blocks - but here's a mcedit schematic of the telescope so you can be shure http://epic.mycraft.pl/vla.schematic (80block height) ;]

other snow structures look good with the same settings http://ds.mycraft.pl/#/424/64/267/max/smooth-lighting http://epic.mycraft.pl/#/55/64/-28/max/smooth-lighting

i will make a render with the default texturepack in 15h (night:) to be shure that its not a problem with the texturepack...

ghost commented 12 years ago

just remembered something... there are more bugs on my renders - so maybe its a map problem... ? force render didn't help, worldedit //set didn't cover them, destroying manually the invisible blocks and replacing them with new ones didn't help either - finally i did fix some of them selecting a "non problematic area" and covering the bad one with worldedit //stack command

those bugs don't exist in "the real world" hole in the ground http://epic.mycraft.pl/#/-1516/64/-74/max/smooth-lighting hole in the pavement http://playcraft.pl/#/-421/64/197/max/smooth-lighting hole in the wall http://epic.mycraft.pl/#/61/64/-230/max/smooth-lighting

agrif commented 12 years ago

I've figured out that your dish isn't rendering because most of those snow blocks (95% of them in fact) have a data value of 8. Snow blocks aren't supposed to have any data value and this is confusing Overviewer, to the point where they're not drawn at all. I'd be willing to bet that your other problem areas are from stray, unexpected data values. Not sure how they got there though.

I know how to fix this but I'm not yet sure how to fit it into our textures framework. I'll get back to you when I'm done.

edit: do you use voxelsniper on your server, by any chance?

ghost commented 12 years ago

yes - i thought it might be voxelsniper ;]

agrif commented 12 years ago

I was able to reproduce this problem with your schematic, and I've pushed a fix for it in debb14c48b8daf16ea62199e82e57ae5a80422a1. Rerender with this new version (either by using --forcerender or by editing the region around the dish) and your snow dish should appear. Thanks for giving me something awesome to test this bug out on! :D

(Windows builds have been automatically built and uploaded.)

ghost commented 12 years ago

many thanks for the fix, now it looks good http://epic.mycraft.pl/cr/#/243/64/1095/-2/smooth-lighting ;]

ghost commented 12 years ago

http://epic.mycraft.pl/nowa/#/-1528/64/-87/-1/smooth-lighting :P ...I'll upload the schematic tomorrow :)

agrif commented 12 years ago

I think I see where the issue was. I've pushed a fix; could you try it out?

If not, I'll take a look at that schematic tomorrow :).

ghost commented 12 years ago

yes, it helped - thx ;]