search

overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.36k stars 482 forks source link

Stairs render as black with texture pack #581

Closed WillMorrison closed 12 years ago

WillMorrison commented 12 years ago

I recently tried out Overviewer for rendering maps of my server. Rendering the map with no command line options worked fine, but I like my texture pack, and many of the buildings were designed with it in mind. So I tried the following line:

.mineserver/world/ Pictures/Minecraft/serverGmap --textures-path .minecraft/texturepacks/Painterly_1-0-0.zip --rendermodes=smooth-lighting,night,cave --forcerender --north-direction=lower-right

This worked fine, except for a few issues. Some of them have already been covered here, such as the corners of chunks in smooth-lighting mode, or the water not rendering. The one I noticed though, and which I can't find anything about, either in the docs or the issue tracker, is that netherrack stairs all rendered as almost black (though if I brighten up the final image with GIMP, I can see the real texture). Full netherrack blocks and fences rendered fine. This did not appear to affect any other stairs. This happened in all the render modes listed on the above command line, though in cave mode, I can't tell, as the blocks are hidden.

I plan on running a few more tests, with different options and the same texture pack, to see if I can narrow down the problem a bit more for you. If you need the map, texture pack, version info or whatever, please tell me, and I'll get that to you.

Edit: In normal render mode, this does not happen. In lighting mode it does.

agrif commented 12 years ago

I suspect this will also happen in smooth-lighting (and normal lighting) without the custom texture pack. I also suspect that if you go to look at those stairs in-game with smooth lighting turned off in the settings, those stairs will also be black. Could you try these?

There's an old bug in Minecraft that prevents stairs from being lit properly, but the bug doesn't show itself if smooth lighting is turned on in-game. We've worked around it in Overviewer but the work-around doesn't work in all cases.

It could still be something else, but this is my hunch.

By the way, what do you mean by "the water not rendering"? I thought that was fixed. :/

WillMorrison commented 12 years ago

Just tried viewing in minecraft with smooth lighting turned off. Neither fast nor fancy graphics showed those stairs as black or unlit.

As for the water not rendering, here's a screenshot from the final render, in smooth lighting mode. The blue surface of the water is simply absent. http://i44.tinypic.com/97iumx.png

agrif commented 12 years ago

Hm. Could you upload your texture pack somewhere? If you need a place to do it, use our uploader.

Also, what version of overviewer are you using? (use --version)

WillMorrison commented 12 years ago

Minecraft Overviewer 0.4.10 (d0032ac) built on Fri Dec 30 13:23:54 2011

Texture pack is uploading now. It's generated by the Painterly Pack Customizer, if that's relevant or useful at all.

WillMorrison commented 12 years ago

just did a rerender without the texture pack, in lighting mode. You were right, and those stairs do show up as almost black. I guess the texture pack factor is ruled out for at least the stair lighting issue.

agrif commented 12 years ago

I've just pushed a fix for the stairs, and binary packages should be rebuilt in a few minutes.

Have you tested out this particular texture pack in-game? The water.png it provides is completely transparent, so Overviewer is dutifully using this to render completely-transparent water. If it does work in-game, then we'll have to work around another Minecraft bug :P.

A temporary fix would be to enable the MCPatcher water files from the Painterly customizer.

WillMorrison commented 12 years ago

The water renders fine in game. I'll try enabling MCPatcher water files and get back to you.

WillMorrison commented 12 years ago

Ok, rerendered a map with MCPatcher water in the pack, and I've got blue stuff again. Thanks =)

Is the new binary in the APT repository, or do I have to do something other than a package update?

WillMorrison commented 12 years ago

Ok, updated the package in APT and all is good. The stairs are now rendering correctly.

Amazing project, keep up the awesome work!