search

overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.35k stars 480 forks source link

Jungle water coloring #676

Open AltyFox opened 12 years ago

AltyFox commented 12 years ago

in-game jungle water doesn't color: http://is.gd/xasRvu Yet in overviewer it does color: http://map.fuyuri.com/#/324/64/1058/-1/0/0

Could this be fixed?

Fenixin commented 12 years ago

Is this maybe related to the second bug in here?

AltyFox commented 12 years ago

No. Jungle biome's water had never been colored ingame, but it always has been on the map. :\

agrif commented 12 years ago

I'm starting to suspect the game completely ignores watercolor.png. I haven't seen water biome changes in-game except for swamp water, which is done in the code.

AltyFox commented 12 years ago

It is: http://is.gd/tHDFLu

Note the word: unused

Fenixin commented 12 years ago

Although I'm not really sure, I'd way this is a bug in minecraft and it will be eventually fixed, so I think it has no sense to "fix" it in overviewer.

AltyFox commented 12 years ago

It's not a bug. It's been that way for a long time and so far it's intentional.

AltyFox commented 12 years ago

bump

JiFish commented 12 years ago

This problem also seems to effect ocean biomes, which render with dark swamp-like water. I can provide a screenshot if required.

Are you seriously classifying this as not a bug in overviewer? watercolor.png hasn't been used since before Beta and the swamp water colouration was added fairly recently.

agrif commented 12 years ago

I haven't actually seen this recently, so a screenshot would be nice. The normal watercolor.png is not this dramatic, I think. (Using it is still a bug though).

Are you sure it's not a lighting issue?

AltyFox commented 12 years ago

I am certain it's not as it happens on biome boundaries

Sent from my iPod

On May 11, 2012, at 12:46, "Aaron Griffith" reply@reply.github.com wrote:

I haven't actually seen this recently, so a screenshot would be nice. The normal watercolor.png is not this dramatic, I think. (Using it is still a bug though).

Are you sure it's not a lighting issue?

Reply to this email directly or view it on GitHub: https://github.com/overviewer/Minecraft-Overviewer/issues/676#issuecomment-5656743

contre commented 12 years ago

http://contre.us/images/ImproperWaterColor.png take a look at this world.. Pretty sure it shouldn't look like that.

It looks like swamp water and ocean water colors are swapped.

AltyFox commented 12 years ago

http://map.fuyuri.com/#/1907/64/2532/-4/0/0

I'm getting this HORRIBLE miscoloring too

AltyFox commented 12 years ago

@contre More than water is wrong. Everything in that image dealing with biomes is horribly mis-colored. It's happening on my map too. I think it's in relation this commit

https://github.com/overviewer/Minecraft-Overviewer/commit/34e5ddf620b18709ee401edc83ac3d4dd88a43da

aheadley commented 12 years ago

Looks like I'm also getting bit by this: http://thedailyautist.com/map/#/-23961/64/9580/-4/0/0

contre commented 12 years ago

I think I found it, https://github.com/overviewer/Minecraft-Overviewer/commit/34e5ddf620b18709ee401edc83ac3d4dd88a43da#L2R52

agrif commented 12 years ago

@contre, yeppers. Sorry about that everyone, I just pushed a fix. It still uses watercolor.png, but the obvious problems everyone's been having here is because (due to my typo) Overviewer multiplied every ocean biome by a random blue component. Fun!

JonnyJD commented 12 years ago

Yes, that solves the ocean coloring problem for me.

eminence commented 12 years ago

Sounds like this is fixed? If so, closing!

AltyFox commented 12 years ago

Re-opening because this is not fixed. The original issue is still there

AltyFox commented 12 years ago

And looks like I can't re-open

pironic commented 11 years ago

close yet? if not, i suspect we could address with OIL Phase 2.