search

overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.35k stars 480 forks source link

cave rendered one block too high? #887

Closed meoso closed 10 years ago

meoso commented 11 years ago

http://s3.postimage.org/9p9qwedwz/Screenshot_02182013_04_57_04_PM.png http://s3.postimage.org/bbyyhmpyr/Screenshot_02182013_04_57_23_PM.png

you can see by the lava level, it seems to be rendered at an incorrect offset.

???

agrif commented 11 years ago

I think what's happening is, the blocks on the very borders of the chunks are being chopped off. If you look carefully there are lava blocks on the edge that aren't rendered, because just one block in they're stone instead. So instead of rendering one block high, everything is rendering fine except for a skin one block deep around the very edge of the map.

I think this is because cave mode hides all blocks that don't get any skylight, and Overviewer fakes skylight on the very borders so that they don't show up black. This needs to be done with skylight, because it needs to work with the night render modes, so I don't really know any way around this.

eminence commented 10 years ago

Since this is a minor issue, and we have no plans on addressing this, I'm going to close this issue.