search

overviewer / Minecraft-Overviewer

Render high-resolution maps of a Minecraft world with a Leaflet powered interface
https://overviewer.org/
GNU General Public License v3.0
3.36k stars 482 forks source link

Slime overlay fails to account for rotated maps #955

Open Iriel opened 11 years ago

Iriel commented 11 years ago

Users on my server had been complaining that the slime overlay on Overviewer was "wrong" - after checking the random seed code multiple times (and spending time in an integer overflow rabbit hole that I then noticed was already addressed with gcc options), I finally noticed that chunkx/chunkz in the state object are normalized against map rotation, but the slime overlay code has no mechanism to compensate.

I've got a working proof of concept fix, i'll clean it up and submit it if someone more qualified with the codebase doesn't get to it first (basically extract north direction from the regionset and use that to swap/negate the chunk coordinates when testing for slime)

Iriel commented 11 years ago

Checking in again -- I should note I ran into a bit of a brick wall with this, while my proof of concept works just fine for my map - it's hack and there's no clean way at present to ask the map abstraction for the original block coordinates for a specific logical block -- i'm going to have to learn a bit more python in order to properly graft that i somehow unless someone beats me to it (please?)

Iriel commented 10 years ago

Just a note (since I had to rebuild everything for 1.8) that this is still broken. (Slime overlays appear to be extra-broken now, the deepest zoom level looks correct, but one zoom out seems to be explicitly rendered incorrectly rather than derived from the next zoom in.

ghost commented 10 years ago

Confirmed.