overwolf / jar-infection-scanner

Scan jar files for known infections
MIT License
115 stars 13 forks source link

minor bug: "folder/file" field doesn't accept quoted strings #14

Open Twisted-Code opened 1 year ago

Twisted-Code commented 1 year ago

if I have quotes in the path, like when I choose "copy path" for a folder on Windows Explorer, I get this if I forget to remove the quotes:

System.ArgumentException: Illegal characters in path.
   at System.IO.LongPathHelper.Normalize(String path, UInt32 maxPathLength, Boolean checkInvalidCharacters, Boolean expandShortPaths)
   at System.IO.Path.NewNormalizePath(String path, Int32 maxPathLength, Boolean expandShortPaths)
   at System.IO.Path.NormalizePath(String path, Boolean fullCheck, Int32 maxPathLength, Boolean expandShortPaths)
   at System.IO.Path.GetFullPathInternal(String path)
   at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost)
   at System.IO.Directory.GetFiles(String path, String searchPattern, SearchOption searchOption)
   at JarInfectionScanner.Form1.<>c__DisplayClass3_0.<buttonScan_Click>b__0()
   at System.Threading.Tasks.Task.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at JarInfectionScanner.Form1.<buttonScan_Click>d__3.MoveNext()

obviously it is quite minor, but it's probably also quite easy to fix.