search

ovh / celery-director

Simple and rapid framework to build workflows with Celery
https://ovh.github.io/celery-director/
BSD 3-Clause "New" or "Revised" License
534 stars 58 forks source link

Outdated flask package version resulting in import error from itsdangerous (breaking package) #125

Closed CodePint closed 2 years ago

CodePint commented 2 years ago

When trying to run our celery-director project we are getting this error:

cannot import name 'json' from 'itsdangerous' 
(/usr/local/lib/python3.8/site-packages/itsdangerous/__init__.py)

This was caused by a new release of itsdangerous and an unsupported version of Flask being used in requirements.txt https://itsdangerous.palletsprojects.com/en/2.1.x/changes/ https://github.com/pallets/itsdangerous/issues/289 https://github.com/ovh/celery-director/blob/d2d0bfbffbf55b3e624a1393800044f9af7040ce/requirements.txt#L15

The best fix would appear to be updating requirements.txt to use Flask~=2.0.0 https://flask.palletsprojects.com/en/2.0.x/changes/

CodePint commented 2 years ago

These changes to requirements.txt fixed the issue I can create a PR if you would like?
Would you prefer hard pinned requirements or is this okay?

Flask~=2.0.0
Werkzeug~=2.0.0
ncrocfer commented 2 years ago

Sorry for the delay to answer, we prefer hard pinned requirements.