search

ovh / celery-director

Simple and rapid framework to build workflows with Celery
https://ovh.github.io/celery-director/
BSD 3-Clause "New" or "Revised" License
534 stars 58 forks source link

Bugfix: updating flask package version and dependencies #128

Closed CodePint closed 2 years ago

CodePint commented 2 years ago

fix: updating flask package version and dependencies

ref issue: https://github.com/ovh/celery-director/issues/125 ref flask 2.0.0 release: https://flask.palletsprojects.com/en/2.0.x/changes/#version-2-0-0

Signed-off-by: George Eddie geddie@linius.com

ncrocfer commented 2 years ago

For information we just pinned itsdangerous in another PR to unblock it (see https://github.com/ovh/celery-director/pull/122/commits/9e554b11512c87c81b2e8e3d91f2b205cb1baae9).

When you will pin Flask, Werkzeug and click requirements please remove itsdangerous ;)

CodePint commented 2 years ago

Can you please pin your requirements? Flask==xxx for instance.

I think there is benefit to being more flexible on requirement versions. Maybe one to consider. Anyway I've rebased off of master and force pushed the change with the requirements pinned

CodePint commented 2 years ago

Are you able to create a new release once this is merged?

ncrocfer commented 2 years ago

I think there is benefit to being more flexible on requirement versions. Maybe one to consider.

It's a point of view :blush:

Personally I don't agree with that, when I deploy an application I want to be sure my builds are predictable and deterministic. If you don't pin your requirements it's not possible 😉

CodePint commented 2 years ago

Personally I don't agree with that, when I deploy an application I want to be sure my builds are predictable and deterministic. If you don't pin your requirements it's not possible wink

Yeah I understand that argument and agree with the sentiment. I just feel that should be down to the application which uses the framework to ensure this by using something like pip-compile.

Anyway, happy to defer here. Shall we get this merged :) ?

ncrocfer commented 2 years ago

We'll merge it tomorrow. And for the new release we have to review and merge other PRs before it.

CodePint commented 2 years ago

We'll merge it tomorrow. And for the new release we have to review and merge other PRs before it.

Okay understood, will check in tomorrow. I've got one other PR open and a few more to raise.

We are working quite heavily with director at the moment and are trying to see how viable and agile it is working off the main project vs our own branch. Thanks for your time.

ncrocfer commented 2 years ago

Can you please signoff your commit?

CodePint commented 2 years ago

Can you please signoff your commit?

Sure thing, all done.