search

ovh / celery-director

Simple and rapid framework to build workflows with Celery
https://ovh.github.io/celery-director/
BSD 3-Clause "New" or "Revised" License
534 stars 58 forks source link

Add docker redis command to tests README #132

Closed CodePint closed 2 years ago

CodePint commented 2 years ago

Adds an example redis docker run command to the test README

Signed-off-by: George Eddie geddie@linius.com

CodePint commented 2 years ago

It's an interesting point, but there is different way to run a Redis to execute the tests. For instance, I do not even use Docker to run Redis locally. Suggestion, on top of the file, maybe something like this:

Tests
=====

Prerequisite
------------
You need to have a Redis server (>= 4.0) up and running.

Virtualenv
----------
$ (venv) git clone https://github.com/ovh/director && cd director
...

Whilst I appreciate there is more than one way to run the testing deps. It would be nice to have the option of a self contained consistent way of running tests.

I wonder if the docker-compose feature here might help with this? https://github.com/ovh/celery-director/pull/3 I'm happy enough with your proposed amendent though for now.