search

ovh / celery-director

Simple and rapid framework to build workflows with Celery
https://ovh.github.io/celery-director/
BSD 3-Clause "New" or "Revised" License
534 stars 58 forks source link

Celery 5 upgrade and compliance #137

Closed CodePint closed 2 years ago

CodePint commented 2 years ago

Upgrading to celery 5

Change Notes

Package Upgrades

Signed-off-by: George Eddie geddie@linius.com

ncrocfer commented 2 years ago

Thanks for this PR, we'll review & merge it next week if all our internal tests pass ;)

Meanwhile can you run black on the code please? (the linter failed https://github.com/ovh/celery-director/runs/5515166540?check_suite_focus=true).

CodePint commented 2 years ago

Thanks for this PR, we'll review & merge it next week if all our internal tests pass ;)

Meanwhile can you run black on the code please? (the linter failed https://github.com/ovh/celery-director/runs/5515166540?check_suite_focus=true).

Sure thing, I'll do that now and force push

CodePint commented 2 years ago

Thanks for this PR, we'll review & merge it next week if all our internal tests pass ;) Meanwhile can you run black on the code please? (the linter failed https://github.com/ovh/celery-director/runs/5515166540?check_suite_focus=true).

Sure thing, I'll do that now and force push

ncrocfer commented 2 years ago

Again sorry @CodePint for the delay between the review and the merge. I was going to merge this PR but I just discover it breaks the dev extra requirement:

$ pip install -e ".[dev]"
[...]
ERROR: Cannot install celery-director and celery-director[dev]==0.4.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    celery-director[dev] 0.4.0 depends on click==7.0
    black 20.8b1 depends on click>=7.1.2

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

The conflict is between the click dependency of black and the one we set in the requirements.txt file. Can you please fix your PR?

I promise to be quick this time to merge it ;)

ncrocfer commented 2 years ago

@CodePint we created another PR here: #147

We keep your commit with your name and we added you as an official contributors ;) Thanks a lot for your help on this project !