search

ovh / celery-director

Simple and rapid framework to build workflows with Celery
https://ovh.github.io/celery-director/
BSD 3-Clause "New" or "Revised" License
534 stars 58 forks source link

feat(ui) add favicon and allow custom repo #141

Closed PaulinCharliquart closed 2 years ago

PaulinCharliquart commented 2 years ago

Fix issue #140. Add favicon and add option to customize repo link in UI.

Signed-off-by: Paulin Charliquart paulincharliquart@gmail.com

anthonyolea commented 2 years ago

Hi,

What is the need to set a custom repo? The Celery Director official repo is this one.

PaulinCharliquart commented 2 years ago

Hi,

What is the need to set a custom repo? The Celery Director official repo is this one.

hi @anthonyolea,

When used in production, official repository doesn't make always sense for end users. With a custom link, I can provide an easy way to access workflows.yml and tasks stored else where.

Kind regards, Paulin

PaulinCharliquart commented 2 years ago

and fix #144

anthonyolea commented 2 years ago

For now, we will not change the header to add the logo, also we will not going further with the favicon. So there is no need to move the logo into director/static/.

Can you just open a brand-new PR (easier this way) with only the DIRECTOR_REPO_LINK feature?

You have to start or rebase your branch from master which was updated with new versions of black, mkdocs,... to avoid issues with python >=3.7.