search

ovh / docs

Official repository containing all docs & guides of OVH Group
https://help.ovhcloud.com/csm/en-gb-documentation?id=kb_home
Other
224 stars 361 forks source link

fix(LDP): port missing in Bonfire guide code snippets #6651

Closed jehuty0shift closed 3 months ago

jehuty0shift commented 3 months ago

Hi, this PR fixes a missing port in this guide preventing users to connect the CLI to Logs Data Platform. The default port changed years ago but wasn't reflected in the guide. The US launch needs all LDP guides to be up to date, hence the dependency priority.

After editing: This PR also remove a non working code snippet from the guide and explain more another feature.

tcpdumpfbacke commented 3 months ago

If it is a fix on an existing guide (looks like it), then I assume it is NOT an upcoming feature (Priority: Dependency)?

tcpdumpfbacke commented 3 months ago

Thank you @jehuty0shift !

jehuty0shift commented 3 months ago

Thanks for the review, Indeed it is not an upcoming product. However this guide need to be updated to allow the proper launch of the LDP product in The US. They use OVH guides to populate their documentation website. If the guides are not working or obsolete, the launch won't happen. Hence the dependency. The launch is scheduled before the end of Q4 IIRC.

tcpdumpfbacke commented 2 months ago

Thanks! For future reference: The label means that the guide update must wait for something else to happen. This is the opposite case. "Urgent" label would have been better. Or we need a new one. :)