feat(manager-components): add load more button in datagrid - Githubissues

ovh / manager

OVHcloud Control Panel

https://ovh.github.io/manager/

BSD 3-Clause "New" or "Revised" License

206 stars 96 forks source link

feat(manager-components): add load more button in datagrid #12154

Open aboungnaseng-ovhcloud opened 3 weeks ago

aboungnaseng-ovhcloud commented 3 weeks ago

Question	Answer
Branch?	`develop`
Bug fix?	no
New feature?	yes/
Breaking change?	no
Tickets	MANAGER-13931
License	BSD 3-Clause

[x] Try to keep pull requests small so they can be easily reviewed.
[x] Commits are signed-off
[x] Only FR translations have been updated
[x] Branch is up-to-date with target branch
[x] Lint has passed locally
[x] Standalone app was ran and tested locally
[x] Ticket reference is mentioned in linked commits (internal only)
[x] Breaking change is mentioned in relevant commits

Description

Add load more button in datagrid
create custom hook to handle data for APIV2, APIV6 (with or without iceberg)

Related

aboungnaseng-ovhcloud commented 2 weeks ago

@aboungnaseng-ovhcloud, I found 2 issues with respect to Sorting.

In useResourcesV6, the sorting is applied only on the displayed data but it has to be applied on the entire dataset.

In useIcebergV6, if we click on "Load More" and then Sort any column, there are multiple queries fired.

OK, I have fix your feedback 👍

aboungnaseng-ovhcloud commented 1 week ago

Sorting is not consistent with 0

Okay I have pushed a fix for it

sonarcloud[bot] commented 5 hours ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud