[manager-components]: Typescript `strict` mode is not enabled

[fredericvilcot]

On which entity, you would like to report a bug?

The whole package

Description

In the tsconfig.json file, there is no strict mode enabled, and in a lesser extent the strictNullChecks mode. There are two main issues with that:

• we do not type check null | undefined assertions, so that may lead to TypeErrors @runtime
• if we want to enable the strict mode in another package / app that consumes the lib by importing the @ovhcloud/manager-components, this causes errors during the build phase by the tsc engine because the local "skipLibCheck": true has no effect on it.

I'll suggest to enable the strict mode (or at least the strictNullCheck mode) in the tsconfig.json file and to fix all related TypeErrors so that we improve global performance and limit bugs.

Steps to reproduce

1. yarn install
2. add "strict: true" to tsconfig.json
3. yarn build

Browser

Firefox

Operating System

• [X] macOS
• [ ] Windows
• [ ] Linux

Additional Information

[aboungnaseng-ovhcloud]

I have seen the issues with Frederic, if we want to switch strict mode option in tsconfig file of the manager component lib, we have to correct all the typescript errors in the lib.

After that, react apps that import manager component lib can switch to strict mode too.