Mistranslation in en_GB on ip_table_manage_reverse* && server_tab_IP_*reverse*

[speed47]

Describe the bug There is a mistranslation in en_GB

To Reproduce Steps to reproduce the behavior:

1. Go to the IP page (https://www.ovh.com/manager/dedicated/#/ip)
2. Click on the "..." button on the right of any IP
3. See that the action "modify the reverse path" is very confusing

Expected behavior This should be called something along the lines of:

• Modify the reverse (informal)
• Modify the reverse DNS name (more technically correct)
• Modify the PTR record (the most technically correct / formal way to call it, but not that often called this way in usual conversations)

I would probably go for "Modify the reverse DNS name" if I were to choose, but it's your call ;)

Additional context Rough diff of where you have to make the changes:

diff --git a/packages/manager/apps/dedicated/client/app/dedicated/server/details/translations/Messages_en_GB.json b/packages/manager/apps/dedicated/client/app/dedicated/server/details/translations/Messages_en_GB.json
index e7a9009d1e..7bfa1b9ad9 100644
--- a/packages/manager/apps/dedicated/client/app/dedicated/server/details/translations/Messages_en_GB.json
+++ b/packages/manager/apps/dedicated/client/app/dedicated/server/details/translations/Messages_en_GB.json
@@ -16,10 +16,10 @@
   "server_tab_IP_table_header_security": "Firewall",
   "server_tab_IP_table_firewall": "Firewall",
   "server_tab_IP_table_manage_reverse": "Modify reverse",
-  "server_tab_IP_table_delete_reverse_success": "The reverse has been deleted.",
-  "server_tab_IP_table_delete_reverse_failure": "An error has occurred deleting the reverse",
-  "server_tab_IP_table_manage_reverse_success": "The reverse path has been updated.",
-  "server_tab_IP_table_manage_reverse_failure": "An error has occurred updating the reverse",
+  "server_tab_IP_table_delete_reverse_success": "The reverse DNS name has been deleted.",
+  "server_tab_IP_table_delete_reverse_failure": "An error has occurred deleting the reverse DNS name",
+  "server_tab_IP_table_manage_reverse_success": "The reverse DNS name has been updated.",
+  "server_tab_IP_table_manage_reverse_failure": "An error has occurred updating the reverse DNS name",
   "server_tab_IP_table_manage_mac": "Modify virtual MAC address",
   "server_tab_IP_table_manage_mitigation_AUTO": "Mitigation: automatic mode ",
   "server_tab_IP_table_manage_mitigation_FORCED": "Mitigation: forced mode",
diff --git a/packages/manager/apps/dedicated/client/app/ip/ip/reverse/update/translations/Messages_en_GB.json b/packages/manager/apps/dedicated/client/app/ip/ip/reverse/update/translations/Messages_en_GB.json
index bd5fcb1f43..0848d2f83c 100644
--- a/packages/manager/apps/dedicated/client/app/ip/ip/reverse/update/translations/Messages_en_GB.json
+++ b/packages/manager/apps/dedicated/client/app/ip/ip/reverse/update/translations/Messages_en_GB.json
@@ -1,8 +1,8 @@
 {
- "ip_table_manage_reverse": "Modify the reverse path",
- "ip_table_manage_reverse_question": "Enter a valid reverse path for this IP, and click on \"Confirm\".",
- "ip_table_manage_reverse_success": "The reverse path has been updated.",
- "ip_table_manage_reverse_failure": "An error has occurred updating the reverse path. {{ message }}",
+ "ip_table_manage_reverse": "Modify the reverse DNS name",
+ "ip_table_manage_reverse_question": "Enter a valid reverse DNS name for this IP, and click on \"Confirm\".",
+ "ip_table_manage_reverse_success": "The reverse DNS name has been updated.",
+ "ip_table_manage_reverse_failure": "An error has occurred updating the reverse DNS name. {{ message }}",
  "ip_table_manage_reverse_confirm": "Confirm",
  "ip_table_manage_reverse_cancel": "Cancel",
  "ip_table_manage_reverse_invalid": "Please specify a valid format."

[antleblanc]

Thanks @speed47 for reporting us this issue.

Action with the given label "modify the reverse path" it appears only once.

$ git grep -i "modify the reverse path"
packages/manager/apps/dedicated/client/app/ip/ip/reverse/update/translations/Messages_en_GB.json: "ip_table_manage_reverse": "Modify the reverse path",

This translation is based on the original content (French) which says:

Modifier le reverse

see: https://github.com/ovh/manager/blob/master/packages/manager/apps/dedicated/client/app/ip/ip/reverse/update/translations/Messages_fr_FR.json#L2

Would you recommend us to update the original translation? If yes, please let us know. Do not hesitate to provide us expected French content.

According to the full diff, would you recommend us to update (also) the original content (French)?

Based on:

- packages/manager/apps/dedicated/client/app/dedicated/server/details/translations/Messages_en_GB.json:
  - server_tab_IP_table_delete_reverse_success
  - server_tab_IP_table_delete_reverse_failure
  - server_tab_IP_table_manage_reverse_success
  - server_tab_IP_table_manage_reverse_success

Here is the original content (French): https://github.com/ovh/manager/blob/371fc8ea6d2f9fabf069fdc38a7d47621c1286cb/packages/manager/apps/dedicated/client/app/dedicated/server/details/translations/Messages_fr_FR.json#L19-L22

Based on:

- packages/manager/apps/dedicated/client/app/ip/ip/reverse/update/translations/Messages_en_GB.json:
  - ip_table_manage_reverse
  - ip_table_manage_reverse_question
  - ip_table_manage_reverse_success
  - ip_table_manage_reverse_failure

Here is the original content (French): https://github.com/ovh/manager/blob/371fc8ea6d2f9fabf069fdc38a7d47621c1286cb/packages/manager/apps/dedicated/client/app/ip/ip/reverse/update/translations/Messages_fr_FR.json#L2-L5

Thank you

[speed47]

Hey, sorry for the delay!

The french sentence "modifier le reverse" is alright, there is no confusion about what it can mean (it implicitly means "modifier le reverse DNS"), I think we can leave it as-is.