ovh / node-ovh

Node.js wrapper for the OVH APIs
http://ovh.github.io/node-ovh
Other
133 stars 27 forks source link

Access to 'GET /auth/currentCredential' route #20

Open bhubr opened 7 years ago

bhubr commented 7 years ago

Hi there from Toulouse ;).

I just started playing around with the Node API wrapper. I got my consumer key and validated it online. Then I wanted to access GET /auth/currentCredential route and got the following response:

{ error: 401, message: 'You must login first' }

Now I noticed that path check for setting the X-Ovh-Consumer header which obviously returns false for a request to any /auth/* route. I think that it is the culprit, as commenting out the check, for test purposes, seemed to work, and I got my expected response:

{ ovhSupport: false,
  status: 'validated',
  applicationId: 38683,
  credentialId: 116223292,
  rules: 
   [ { method: 'GET', path: '/domain/zone/*' },
     { method: 'POST', path: '/domain/zone/*' },
     { method: 'PUT', path: '/domain/zone/*' },
     { method: 'DELETE', path: '/domain/zone/*' } ],
  expiration: '2017-07-12T08:08:44+02:00',
  lastUse: null,
  creation: '2017-07-11T08:07:49+02:00' }

Checking out the code for the PHP, there doesn't seem to be such a condition for setting the Consumer and Signature headers. Shouldn't the check on path be more specific? Or am I getting something wrong?

rbeuque74 commented 7 years ago

Yes it should indeed. If we want to be more accurate, SDKs could check the JSON specifications (https://api.ovh.com/1.0/auth.json) in order to test if route havev "noAuthentification" or not, that would be the best way to determine if the API need customer_key or not ;)

legraphista commented 7 years ago

+1

Nox-404 commented 6 years ago

I made a PR for this #28

Silbad commented 3 years ago

Hello, same pb...

sinux-l5d commented 3 years ago

This i still an issue, #28 don't seems to be merged