Fix issue #3: HTTPS proxy support through custom agent

ovh / node-ovh

Node.js wrapper for the OVH APIs

http://ovh.github.io/node-ovh

Other

129 stars 27 forks source link

Fix issue #3: HTTPS proxy support through custom agent #5

Open debrouxl opened 9 years ago

debrouxl commented 9 years ago

I implemented the outcome of the discussion in issue #3 , and made a quick local test from behind an HTTPS proxy, which accessed the server successfully.

As far as naming is concerned, maybe the property in params should be named "httpsAgent" for consistency, or the "https" / "HTTPS" strings should go away ?

yadutaf commented 9 years ago

Thanks for your contribution! Quality is a must-have for OVH. Can you provide relevant tests and documentation for this patch? Thanks.

debrouxl commented 9 years ago

do you mean that you'd like to see more documentation comments, a note in the readme, or / in addition to something else ?
unit testing would require going through a real HTTP proxy. Would a trivial proxy (pure request forward) created by the test infrastructure for the sole purpose of testing be acceptable ?

loganmzz commented 4 years ago

Still no support for proxy settings ?