search

ovh / node-ovh

Node.js wrapper for the OVH APIs
http://ovh.github.io/node-ovh
Other
129 stars 27 forks source link

API endpoints started returning 204 for No Content but client throws error #51

Open mcdado opened 10 months ago

mcdado commented 10 months ago

The client expects response http code 200 but some endpoints (in my case domain zone refresh) started returning 204:

https://github.com/ovh/node-ovh/blob/06d61afd5e21c9872b80de2695f13ef2be1b8ae8/lib/ovh.es5.js#L197

https://github.com/ovh/node-ovh/blob/06d61afd5e21c9872b80de2695f13ef2be1b8ae8/lib/ovh.es6.js#L176

Should be res.statusCode >= 400

mcdado commented 10 months ago

I did a very quick search, didn't see that I'm referring to another call. Either way, the recently merge #50 is not published yet to npm, so the issue is still active.