SCP wrapper doesn't check for the "BASTION_CONF_FILE" env var

ovh / the-bastion-ansible-wrapper

Using Ansible through The Bastion

https://ovh.github.io/the-bastion/

Apache License 2.0

35 stars 12 forks source link

SCP wrapper doesn't check for the "BASTION_CONF_FILE" env var #20

Closed Krenodeno closed 1 year ago

Krenodeno commented 1 year ago

Hi,

I just saw that scpwrapper.py doesn't check the presence of the bastion vars via a config file that path would be overridden by that BASTION_CONF_FILE like sshwrapper.py does. That means the SCP wrapper doesn't support that way of configuring the wrapper.

The code ranges to copy are line 18, and line 42 to line 50 from sshwrapper.py

Krenodeno commented 1 year ago

Also, the use of BASTION_CONF_FILE is not mentioned here

jriouovh commented 1 year ago

Thank you for this report. It's now fixed.