Lazy expansion of json payloads that we get from user executors

ovh / venom

🐍 Manage and run your integration tests with efficiency - Venom run executors (script, HTTP Request, web, imap, etc... ) and assertions

Apache License 2.0

1.06k stars 144 forks source link

Lazy expansion of json payloads that we get from user executors #735

Closed fokion closed 3 months ago

fokion commented 1 year ago

This is done in order to avoid expanding and storing big payloads that we dont need and we dont use for assertions. The flag is called VENOM_NO_JSON_EXPANSION.

fokion commented 1 year ago

https://github.com/ovh/venom/pull/708

fokion commented 1 year ago

The idea is that you can have a big JSON payload , by default we will try to unmarshal it and we may not use the new keys in any assertion. That will cause issues with performance as the constant unmarshalling , copying of values with increase memory and cpu usage. The point here is to unmarshal this payload lazily and for now have that feature tested under a flag so that we dont affect everyone.

yesnault commented 3 months ago

Closing this pull-request for now: we don't want to add a global flag, unless it's a new feature that we want to test and include in the next major release.