search

ovh / venom

🐍 Manage and run your integration tests with efficiency - Venom run executors (script, HTTP Request, web, imap, etc... ) and assertions
Apache License 2.0
1.06k stars 144 forks source link

path of the Venom binary in the container image is unusual #811

Open elchenberg opened 3 months ago

elchenberg commented 3 months ago

In the container image docker.io/ovhcom/venom:v1.2.0 the path of Venom binary is /usr/local/venom.

The directory /usr/local is not in the PATH (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin).

This means that I need to look up (because I am forgetful) and use the full path to the binary if I want to run commands inside a Venom container that is already running (eg. docker run --entrypoint sh -it docker.io/ovhcom/venom:v1.2.0). I am also using the Venom image in GitLab CI and have to use the full path there, too, because the GitLab Runner starts the container with a shell and uses the shell to run Venom.

Although this is only a little inconvenience it would be nice if the binary could be placed at /usr/local/bin/venom instead so that I do not need to use the full path anymore.

-COPY dist/venom.linux-amd64 /usr/local/venom
+COPY dist/venom.linux-amd64 /usr/local/bin/venom

 VOLUME /workdir/results
 VOLUME /workdir/tests
 WORKDIR /workdir

-ENTRYPOINT ["/usr/local/venom"]
+ENTRYPOINT ["/usr/local/bin/venom"]

https://github.com/ovh/venom/blob/5e480f08bc5c431442ef586c948d3a58d47d5e07/Dockerfile#L6