search

ovidiuch / react-component-playground

Minimal frame for loading and testing React components in isolation.
MIT License
76 stars 16 forks source link

Searchable fixture tree #40

Closed catalinmiron closed 8 years ago

catalinmiron commented 8 years ago

Closes #39

component-playground-searchable-fixtures

@skidding this PR is not ready for CR since I didn't wrote the tests (TDD for the win) 🍧 But you can comment out on the styles, maybe we can change something.

ovidiuch commented 8 years ago

If you haven't already, try to see how it looks to have the input take up the entire space .filter-input-container is taking now (in other words no margin around input). Might give it a more minimal look, but might also be less intuitive. Looking great either way! 👯

catalinmiron commented 8 years ago

@skidding please review

normal state focused state
image image
catalinmiron commented 8 years ago

if the release is not working please do the following

git push origin v0.4.1; git push origin --tags
ovidiuch commented 8 years ago

Looks good and works like a charm.

Did you consider searching through the component names as well? It might be weird, but I think it might be more common to search for a component than for a specific fixture name. Wdyt?

catalinmiron commented 8 years ago

@skidding please review. I've added fuzzysearch, I hope you like it and find it useful. Thanks component-playground-fuzzysearch

ovidiuch commented 8 years ago

Beautiful! 🌹