search

ovilab / atomify

Atomify - a realtime LAMMPS visualizer
GNU General Public License v3.0
149 stars 20 forks source link

Issues with updateSelectionData #415

Closed andeplane closed 6 years ago

andeplane commented 6 years ago

Not sure what it is yet, but I've had a couple of crashes in updateSelectionData. Recheck the logic!

Can we access an array out of bounds?

andeplane commented 6 years ago 
Thread 21 Crashed:: QThread
0   net.ovilab.atomify              0x000000010825ec6f System::updateSelectionData(LAMMPS_NS::LAMMPS*) + 1071
1   net.ovilab.atomify              0x000000010825ddc5 System::synchronize(LAMMPSController*) + 1845
2   net.ovilab.atomify              0x0000000108232997 LAMMPSController::synchronizeLAMMPS(int) + 55
3   net.ovilab.atomify              0x00000001083fe252 LAMMPS_NS::FixAtomify::end_of_step() + 242 (fix_atomify.cpp:105)
4   net.ovilab.atomify              0x00000001085bfc92 LAMMPS_NS::Modify::end_of_step() + 98 (modify.cpp:476)
5   net.ovilab.atomify              0x0000000108920731 LAMMPS_NS::Verlet::run(int) + 1473 (verlet.cpp:344)
6   net.ovilab.atomify              0x00000001088e017b LAMMPS_NS::Run::command(int, char**) + 2475 (run.cpp:184)
7   net.ovilab.atomify              0x000000010856a107 void LAMMPS_NS::Input::command_creator<LAMMPS_NS::Run>(LAMMPS_NS::LAMMPS*, int, char**) + 55 (input.cpp:872)
8   net.ovilab.atomify              0x000000010856b8a1 LAMMPS_NS::Input::execute_command() + 1809 (input.cpp:854)
9   net.ovilab.atomify              0x000000010856add5 LAMMPS_NS::Input::file() + 1157 (input.cpp:251)
10  net.ovilab.atomify              0x000000010856c5cb LAMMPS_NS::Input::file(char const*) + 251 (input.cpp:285)
11  net.ovilab.atomify              0x000000010857f298 lammps_file + 24 (library.cpp:209)
12  net.ovilab.atomify              0x0000000108233a72 LAMMPSController::run() + 258
13  net.ovilab.atomify              0x0000000108222bcf SimulatorWorker::workAndUnlock(Simulator*) + 15
14  org.qt-project.QtCore           0x000000010ba84e44 QObject::event(QEvent*) + 788 (qobject.cpp:183)
15  org.qt-project.QtWidgets        0x000000010c8b0ee2 QApplicationPrivate::notify_helper(QObject*, QEvent*) + 306 (qcoreapplication_p.h:104)
16  org.qt-project.QtWidgets        0x000000010c8b21ff QApplication::notify(QObject*, QEvent*) + 383 (qapplication.cpp:3083)
17  org.qt-project.QtCore           0x000000010ba5ba0f QCoreApplication::notifyInternal2(QObject*, QEvent*) + 159 (qcoreapplication.cpp:1048)
18  org.qt-project.QtCore           0x000000010ba5cbe2 QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) + 850 (qcoreapplication.h:234)
19  org.qt-project.QtCore           0x000000010bab1759 QEventDispatcherUNIX::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) + 73 (qeventdispatcher_unix.cpp:472)
20  org.qt-project.QtCore           0x000000010ba57562 QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) + 418 (atomic:848)
21  org.qt-project.QtCore           0x000000010b8a0d11 QThread::exec() + 113 (qthread.cpp:522)
22  org.qt-project.QtCore           0x000000010b8aa267 QThreadPrivate::start(void*) + 359 (qthread_unix.cpp:399)
23  libsystem_pthread.dylib         0x00007fffeac4393b _pthread_body + 180
24  libsystem_pthread.dylib         0x00007fffeac43887 _pthread_start + 286
25  libsystem_pthread.dylib         0x00007fffeac4308d thread_start + 13
andeplane commented 6 years ago

Fixed in referencing commit