b4.4 bug: deprecate -t since it is gone in main, mixes poorly with -l, and exits when there is no preexisting log

ovis-hpc / ldms

OVIS/LDMS High Performance Computing monitoring, analysis, and visualization project.

https://github.com/ovis-hpc/ovis-wiki/wiki

Other

100 stars 52 forks source link

b4.4 bug: deprecate -t since it is gone in main, mixes poorly with -l, and exits when there is no preexisting log #1488

Closed baallan closed 1 week ago

baallan commented 3 weeks ago

truncating the log now works correctly whether the old log exists or not and independent of the ordering of -l and -t commands.

baallan commented 3 weeks ago

fixes #1443

tom95858 commented 3 weeks ago

@baallan, @nichamon this 'feature' has been removed from top of tree. Should we consider getting rid of this in 4.4? I know it's convenient to crush the log file at start up, but it can trivially be achieved in other ways with the new 'rm' command ;-)

baallan commented 3 weeks ago

@tom95858 If it is gone from main, I'm fine with making it a no-op+warning in 4.4. Just deleting it could break working scripts. But in theory this should be a community decision?

A patch to do that might also add deprecation warnings in 4.4 about all other options that are going away/gone in main.

baallan commented 2 weeks ago

@tom95858 revised this pr to deprecate -t.

nichamon commented 2 weeks ago

@baallan Thanks for making the revisions. Given that your latest commit removes the -t option completely, would you consider dropping the first commit dcc50b5?

baallan commented 2 weeks ago

@nichamon if we could just check the squash box on the pr, that should take care of it. I don't have any pull/merge controls on the github repo, however.

baallan commented 2 weeks ago

@nichamon found the branch and squashed it.