search

ovis-hpc / ldms

OVIS/LDMS High Performance Computing monitoring, analysis, and visualization project.
https://github.com/ovis-hpc/ovis-wiki/wiki
Other
100 stars 52 forks source link

Recently landed PR #1490 breaks static decomposition default ("fill") string #1495

Closed morrone closed 1 week ago

morrone commented 3 weeks ago

Recently landed PR #1490 breaks static decomposition. Here's the error that I am seeing:

Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024: ERROR     : strgp 'kafka.label_ibmad': row '0': col[dst] 'cluster','fill' error 22: Unsupported JSON value.
Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024: ERROR     : msg_no 67: error 22: strgp 'kafka.label_ibmad': row '0': col[dst] 'cluster','fill' error 22: Unsupported JSON value.
Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024: ERROR     : Configuration error at line 67 (/etc/ldmsd/ldmsd@aggregator.conf)
Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024:           : LDMSD_ LDMS Daemon exiting...status 22, Error 22 processing configuration file '/etc/ldmsd/ldmsd@aggregator.conf'
Nov 01 15:35:52 hetchy14 ldmsd[263393]: Fri Nov 01 15:35:52 2024:           : LDMSD_ cleanup end.

And this almost certainly is due to this line:

                        {"src":"cluster", "dst":"cluster", "type":"char_array", "array_len":12, "fill":"hetchy"},

Probably there should be tests of all default fill types. If it broke this, it may have broken other default fills as well.

tom95858 commented 2 weeks ago

@narategithub it looks like we may have missed a type or two, or we inadvertently changed a type name?

tom95858 commented 2 weeks ago

@morrone, thanks for helping test this.

narategithub commented 2 weeks ago

@morrone thanks for catching this. I'm updating the test script to include all "fill" types & fixing the fill.