ovis-hpc / ldms

OVIS/LDMS High Performance Computing monitoring, analysis, and visualization project.
https://github.com/ovis-hpc/ovis-wiki/wiki
Other
100 stars 52 forks source link

[b4.4] Fix "fill" handling in static decomposition #1500

Closed narategithub closed 1 week ago

narategithub commented 2 weeks ago

This PR addressed #1495 . This PR (with #1498 and #1499) has been tested with these test cases in ldms-test repo (branch b4.4):

morrone commented 2 weeks ago

Still broken, but in a different way:

ldmsd: decomp_static.c:1014: resolve_col: Assertion `mlen' failed.

Error message isn't terribly helpful. I am not sure what it isn't liking.

narategithub commented 2 weeks ago

@morrone can I see your config?

narategithub commented 2 weeks ago

@morrone never mind me. It was an incorrect assertion that mlen should not be 0 for all types. The length should be ignored for non-array types. The fix is on the way ...

narategithub commented 2 weeks ago

@morrone Could you please give this another whirl?

morrone commented 2 weeks ago

@narategithub It looks like there are no longer any errors thrown with my config and your latest fix. My testbed is slightly broken (networking issues) at the moment, so I can't quite check the full decomposition output for correctness. But I can see that my "cluster" default fill is at least working, so that is a good sign.

narategithub commented 2 weeks ago

Thank you, @morrone !