search

ovis-hpc / sos

sos pre-release stable.
https://github.com/ovis-hpc/sos/wiki
Other
4 stars 7 forks source link

SOS libraries should be combined and renamed #27

Open tom95858 opened 4 years ago

tom95858 commented 4 years ago

Hi @morrone, @baallan,

The SOS libraries need to be moved to $pkglibdir and renamed to avoid collision with existing libraries.

I am fairly certain that RHEL, at least, has a libsos library already. If $pkglibdir is /usr/lib[64] this will cause collisions with -lsos.

If we are not satisfied with requiring -L$pkglibdir/sos -lsos or something like (we have already litigated the inevitability of library name collision discussion) then libsos needs a new name. SOS is independent of LDMS/OVIS so libldms_sos, etc... gives me pause.

I'll need to propose a new name that is unique and doesn't give the undue impression of dependency. But overall, I think we are at:

$pkglibdir/lib[new_name].so $pkglibdir/[new_name]_plugins

baallan commented 4 years ago

@tom95858 I thought you had already shifted to sosdb for packaging. That seems fine for lib name too. Though by convention if the configure.ac package is sosdb, then (e.g. rhel) libdir is /usr/lib64 and pkglibdir is /usr/lib64/sosdb.

tom95858 commented 4 years ago

Hi @baallan, yes libsosdb.so seems like a reasonable name