Fix sos_cmd's JSON results of all SOS value types

ovis-hpc / sos

sos pre-release stable.

https://github.com/ovis-hpc/sos/wiki

Other

4 stars 7 forks source link

Fix sos_cmd's JSON results of all SOS value types #59

Closed nichamon closed 2 years ago

nichamon commented 2 years ago

Commit bfc23855 introduced a bug that sos_cmd prints SOS_TYPE_BYTE_ARRAY and SOS_TYPE_CHAR_ARRAY without double-quotes. The patch addresses the bug and the formats of all SOS value types.

nichamon commented 2 years ago

@tom95858 @narategithub found a bug caused by the previous pull request that fixes the JSON format of SOS_TYPE_BYTE_ARRAY. The patch in the pull request uses a switch-case to make sure that the logic addresses all SOS types.

narategithub commented 2 years ago

@nichamon This looks OK to me.

tom95858 commented 2 years ago

@nichamon, should I take this pull request?

nichamon commented 2 years ago

should I take this pull request?

Yes, please!