search

ovis-hpc / sos

sos pre-release stable.
https://github.com/ovis-hpc/sos/wiki
Other
4 stars 7 forks source link

Adding path object to Sos.Session so that DsosContainer gets path variable #93

Closed bschwal closed 11 months ago

bschwal commented 11 months ago

In SOS-6 it does not appear that the DsosContainer object's path_ variable ever gets set. I updated Sos.Session to have a path variable and then pass that into DsosContainer on init. By doing this I can look at DsosContainer itself to see what container it is pointing to without needing to pass that information along elsewhere.

tom95858 commented 11 months ago

Hi @bschwal, I'll take a look at this, but I don't think this change will do what you want. I'll confirm, but a single session may have multiple containers open.

tom95858 commented 11 months ago

@bschwal, the DsosContainer class already has a path() method. But I will add a dsos_container_path() function for C clients as well.

bschwal commented 11 months ago

@tom95858 it does have a path() method but the path variable is never set by anything. This change ensures it is. I've tested this out and it does perform how I'd like (in my implementation at least).

bschwal commented 11 months ago

I think I saw in SOS-5 that the path_ variable does get set but no longer in SOS-6.

tom95858 commented 11 months ago

Hi @bschwal, I just pushed a change that hopefully resolves this issue. Please take a look.

bschwal commented 11 months ago

Hi @tom95858 I tried out that change and it looks like it works just fine. It does come back as a bytes object rather than a string which I can work around but just wanted you to be aware. Thanks!

tom95858 commented 11 months ago

@bschwal can you confirm that this is fixed in the top of tree?

bschwal commented 11 months ago

Yep all good!

tom95858 commented 11 months ago

Great, thanks...

On Mon, Oct 16, 2023 at 7:50 AM bschwal @.***> wrote:

Yep all good!

— Reply to this email directly, view it on GitHub https://github.com/ovis-hpc/sos/pull/93#issuecomment-1764527802, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVTPXEVLQZWHWDBLVXHPN3X7U3SHAVCNFSM6AAAAAA53COAJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUGUZDOOBQGI . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Thomas Tucker, President, Open Grid Computing, Inc.