search

ovity / octotree

GitHub on steroids
https://www.octotree.io/
GNU Affero General Public License v3.0
22.82k stars 1.78k forks source link

Themes are gone #1096

Closed rozag closed 3 years ago

rozag commented 3 years ago

Description

Themes button is not here anymore and I have to use a theme provided by Github instead of my favorite Octotree's one.

Environment (if bug)

macintacos commented 3 years ago

Was just about to report this, my colors are also all out of whack now (it seems to revert to some default theme instead of the one you previously had selected).

bmoyer240 commented 3 years ago

Looking a bit rough using the "dark dimmed" appearance.

image image

macintacos commented 3 years ago

Ah looks like this is #1094.

danhgit commented 3 years ago

@macintacos yes, the theme issue can be tracked in the other ticket.

@rozag we stopped support Octotree dark themes since 7.1 to focus on supporting the new GitHub's dark themes. Please see the release note below (it's also in the app, if you click the yellow banner in the Octotree sidebar). As mentioned in the that note, you can use GitHub Dark to enable custom themes. Sorry about the inconvenience.

In the latest version of GitHub, its DOM has changed so much and breaks all Octotree's dark themes. In the past, we supported dark themes because GitHub didn't. However, GitHub now supports various dark themes. Ensuring that Octotree works well with these built-in themes is already hard, maintaining our own themes, amidst frequent GitHub DOM changes and lots of CSS selector conflicts, has become increasingly infeasible and resulted in highly brittle code, with lots of !important declarations and other ugly hacks.

After failed attempts to fix the broken themes and through much consideration, we've decided to drop the support for Octotree's dark themes (except in old versions of GitHub Enterprise that use old DOM and styles). We'll focus energy on making sure Octotree works well with GitHub's built-in themes. Those who miss old dark themes can use GitHub Dark, which supports Octotree and has a broad selection of themes.

We apologize for the inconveniences and hope to receive your continued support.

rozag commented 3 years ago

Oh well, that's sad, but I feel your pain, thanks for the quick response.