search

ovity / octotree

GitHub on steroids
https://www.octotree.io/
GNU Affero General Public License v3.0
22.8k stars 1.79k forks source link

Octotree font change options makes text copying very difficult #1155

Closed ahatzz11 closed 1 year ago

ahatzz11 commented 1 year ago

Description

When changing the font settings (either font itself or the text size) in octotree, it can make copying code very difficult because it seems to 'change' the code that is actually present on the screen. It seems like octotree changes the color of the underlying font, and then puts new font on top of it.

Here is an example where I'm trying to copy - name: Create Summary - Fail but it actually ends up copying some text "under" that text and it doesn't align with what my screen shows.

image

This example is from using JetBrains Mono with size 13px. Every change to font seems to do this with varying levels of issue. Happy to give more information if needed!

Environment (if bug)

jibbers42 commented 1 year ago

Same issue. The ghosted text is present when changing the font, but changing the size is what really makes the selectable content drift from the visible content.

mgray88 commented 1 year ago

What is the status with this project? With no response here I fear abandonware, and I don't want to keep paying for something that is broken.

@buunguyen It looks like you have been the main contributor in the past, any insight?

danhgit commented 1 year ago

@ahatzz11 thanks for reporting with details.

@mgray88 I understand your concern, rest assured Octotree is not abandoned and we've been updating it regularly. This bug is a bit tough so I haven't reported back, but we should have the fix soon. Will keep everyone updated.

mgray88 commented 1 year ago

Thank you @danhgit! I want to extend my sincere appreciation for this project. I know GitHub have themselves been implementing some of the functionality natively, but I still find I prefer Octotree. The font/text size is big deal to me, so thank you for reporting back!

ahatzz11 commented 1 year ago

I am super thrilled to hear there is still some work going on for this. The octotree code tree is still far superior to GitHub's in my opinion, Thanks @danhgit!

danhgit commented 1 year ago

@mgray88 @ahatzz11: thank you so much for your support and kind words! I'm happy to let you know that we've released a fix for the bug in version 7.9.1, which is now available on Chrome and will soon be available on other platforms.

mgray88 commented 1 year ago

Significantly improved! There's still a strange behavior with the visual location of the cursor. Not critical though :grin:

Using JetBrains Mono; 14px

I clicked on indexOf and the symbol highlighting works, and I can select text correctly, but that visual cursor that GitHub shows seems to still be aligned with the smaller font size

danhgit commented 1 year ago

@mgray88 missed that... We've just release the fix in 7.9.2. Please look out for that version.

BenjaVR commented 1 year ago

@mgray88 missed that... We've just release the fix in 7.9.2. Please look out for that version.

I still have the cursor thing using v7.9.2 (Chromium / Brave).

danhgit commented 1 year ago

Can you add screenshot?

BenjaVR commented 1 year ago

Sure: image

Note it is blinking now. I think before it was just static.

ahatzz11 commented 1 year ago

@mgray88 @ahatzz11: thank you so much for your support and kind words! I'm happy to let you know that we've released a fix for the bug in version 7.9.1, which is now available on Chrome and will soon be available on other platforms.

Thank you for the fix! Super super glad to see that improvements are still being made, even for little QoL things. Thanks!

danhgit commented 1 year ago

@BenjaVR we fixed the issue in v7.9.3. Please check out and let me know if it works for you. I'm closing the ticket now.

BenjaVR commented 1 year ago

@BenjaVR we fixed the issue in v7.9.3. Please check out and let me know if it works for you. I'm closing the ticket now.

I'm on this version: image

But I still see the blinking cursor while looking at code: image

danhgit commented 1 year ago

The blinking cursor is a GitHub thing I believe. You can disable Octotree and it will still blink.

BenjaVR commented 1 year ago

The blinking cursor is a GitHub thing I believe. You can disable Octotree and it will still blink.

Hmm, when I open a random file on GitHub in an incognito window without any extensions, I do not see the cursor. However, when logged in I do 😁 GitHub feature it is! Thanks 🙂