search

ovity / octotree

GitHub on steroids
https://www.octotree.io/
GNU Affero General Public License v3.0
22.83k stars 1.78k forks source link

Asking for Token after refreshing page on Private Repos #94

Closed DannyDouglass closed 10 years ago

DannyDouglass commented 10 years ago

Steps to reproduce:

  1. Save token in Octotree for private repo
  2. See folders/files as expected
  3. Refresh and re-prompted for token
skelz0r commented 10 years ago

Same here

buunguyen commented 10 years ago

I can't reproduce this bug. Can you check local storage of github.com to see if the key octotree.github_access_token was saved?

DannyDouglass commented 10 years ago

It is not saved when I refresh the page, however the octopress.shown value persists and is equal to true

buunguyen commented 10 years ago

That's very strange. For step 2 to happen, the token must be stored successfully. So at least you should see it's briefly stored. Now, what makes the token go away after is another mystery. Can you debug the method saveToken?

DannyDouglass commented 10 years ago

I'll debug and provide feedback. In regards to chrome's dev tools, I never see the access token on refresh. Get back to you tomorrow with results.

buunguyen commented 10 years ago

@DannyDouglass hi, have you found out the cause?

DannyDouglass commented 10 years ago

No the sidebar doesn't even show up for me anymore (see below).

Probably going to uninstall this plugin.

screen shot 2014-06-04 at 1 29 28 pm

buunguyen commented 10 years ago

Weird. If even the token cannot be saved, there's something funky going on. Octotree uses localStorage to store the token, nothing fancy. If somebody can reproduce it, it should be easy to debug and fix (and submit a PR). Going to close this now.