search

ovn-org / ovn-heater

Mega script to deploy/configure/run OVN scale tests.
Apache License 2.0
12 stars 12 forks source link

Remove 'container' argument from CentralNode, WorkerNode, RelayNode constructors. #181

Open dceara opened 1 year ago

dceara commented 1 year ago

As @mkalcok points out these arguments give the wrong impression that users can choose random names. That's not exactly true. Container names are either (partially) hardcoded in ovn-fake-multinode or can be changed via config. It's probably better to pass the config (and maybe an index or some other unique id) and do the container naming internally.

dceara commented 1 year ago

Originally reported at: https://github.com/ovn-org/ovn-heater/pull/180#discussion_r1341926363