search

ovn-org / ovn-heater

Mega script to deploy/configure/run OVN scale tests.
Apache License 2.0
12 stars 12 forks source link

ovn-tester: do not create transit switch in non-ic mode #188

Closed LorenzoBianconi closed 11 months ago

LorenzoBianconi commented 1 year ago
dceara commented 1 year ago

Thanks for the PR @LorenzoBianconi, but I wonder why we need to remove the transit switch. It doesn't really hurt the single-AZ case, or am I missing something?

Thanks!

LorenzoBianconi commented 1 year ago

Thanks for the PR @LorenzoBianconi, but I wonder why we need to remove the transit switch. It doesn't really hurt the single-AZ case, or am I missing something?

Thanks!

it seems odd to me adding the ts if it is not really used

dceara commented 12 months ago

Thanks for the PR @LorenzoBianconi, but I wonder why we need to remove the transit switch. It doesn't really hurt the single-AZ case, or am I missing something? Thanks!

it seems odd to me adding the ts if it is not really used

On the other hand, it really doesn't cause any issues if it's there and we don't need to have an additional check in the code.

LorenzoBianconi commented 12 months ago

Thanks for the PR @LorenzoBianconi, but I wonder why we need to remove the transit switch. It doesn't really hurt the single-AZ case, or am I missing something? Thanks!

it seems odd to me adding the ts if it is not really used

On the other hand, it really doesn't cause any issues if it's there and we don't need to have an additional check in the code.

honestly I can live with it but the code is almost the same and the output is cleaner so I can't see any blocking point on it :)