Closed martinkennelly closed 11 months ago
I'm seeing data races as well. There are some issues with hybrid overlay. Working on a fix...
2023-10-10T13:12:11.8338229Z WARNING: DATA RACE
2023-10-10T13:12:11.8338659Z Read at 0x00c0006bf000 by goroutine 131:
2023-10-10T13:12:11.8339521Z github.com/ovn-org/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller.(*NodeController).AddNode()
2023-10-10T13:12:11.8340694Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller/ovn_node_linux.go:230 +0x1bc
2023-10-10T13:12:11.8341573Z github.com/ovn-org/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller.NewNode.func1()
2023-10-10T13:12:11.8342667Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller/node.go:116 +0x9c
2023-10-10T13:12:11.8343915Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).syncHandler()
2023-10-10T13:12:11.8345395Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:360 +0x3c6
2023-10-10T13:12:11.8346703Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).processNextWorkItem.func1()
2023-10-10T13:12:11.8348030Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:305 +0x196
2023-10-10T13:12:11.8349064Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).processNextWorkItem()
2023-10-10T13:12:11.8350082Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:322 +0x64
2023-10-10T13:12:11.8350892Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).runWorker()
2023-10-10T13:12:11.8351892Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:273 +0x2e
2023-10-10T13:12:11.8353127Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).runWorker-fm()
2023-10-10T13:12:11.8353575Z <autogenerated>:1 +0x39
2023-10-10T13:12:11.8353954Z k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1()
2023-10-10T13:12:11.8354885Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/wait/backoff.go:226 +0x48
2023-10-10T13:12:11.8355530Z k8s.io/apimachinery/pkg/util/wait.BackoffUntil()
2023-10-10T13:12:11.8356819Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/wait/backoff.go:227 +0xce
2023-10-10T13:12:11.8357467Z k8s.io/apimachinery/pkg/util/wait.JitterUntil()
2023-10-10T13:12:11.8358510Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/wait/backoff.go:204 +0x10d
2023-10-10T13:12:11.8358953Z k8s.io/apimachinery/pkg/util/wait.Until()
2023-10-10T13:12:11.8359936Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/wait/backoff.go:161 +0xd7
2023-10-10T13:12:11.8361022Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).Run.func1()
2023-10-10T13:12:11.8362046Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:218 +0x91
2023-10-10T13:12:11.8362333Z
2023-10-10T13:12:11.8362515Z Previous write at 0x00c0006bf000 by goroutine 124:
2023-10-10T13:12:11.8363284Z github.com/ovn-org/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller.(*NodeController).EnsureHybridOverlayBridge()
2023-10-10T13:12:11.8364498Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller/ovn_node_linux.go:510 +0x6e4
2023-10-10T13:12:11.8365281Z github.com/ovn-org/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller.(*NodeController).AddNode()
2023-10-10T13:12:11.8366260Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller/ovn_node_linux.go:244 +0x464
2023-10-10T13:12:11.8367292Z github.com/ovn-org/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller.NewNode.func1()
2023-10-10T13:12:11.8368734Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller/node.go:116 +0x9c
2023-10-10T13:12:11.8369622Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).syncHandler()
2023-10-10T13:12:11.8370477Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:360 +0x3c6
2023-10-10T13:12:11.8371209Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).processNextWorkItem.func1()
2023-10-10T13:12:11.8372740Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:305 +0x196
2023-10-10T13:12:11.8373929Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).processNextWorkItem()
2023-10-10T13:12:11.8374735Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:322 +0x64
2023-10-10T13:12:11.8375345Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).runWorker()
2023-10-10T13:12:11.8376128Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:273 +0x2e
2023-10-10T13:12:11.8377022Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).runWorker-fm()
2023-10-10T13:12:11.8377452Z <autogenerated>:1 +0x39
2023-10-10T13:12:11.8377802Z k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1()
2023-10-10T13:12:11.8378678Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/wait/backoff.go:226 +0x48
2023-10-10T13:12:11.8379160Z k8s.io/apimachinery/pkg/util/wait.BackoffUntil()
2023-10-10T13:12:11.8379989Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/wait/backoff.go:227 +0xce
2023-10-10T13:12:11.8380462Z k8s.io/apimachinery/pkg/util/wait.JitterUntil()
2023-10-10T13:12:11.8381306Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/wait/backoff.go:204 +0x10d
2023-10-10T13:12:11.8381760Z k8s.io/apimachinery/pkg/util/wait.Until()
2023-10-10T13:12:11.8382895Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/wait/backoff.go:161 +0xd7
2023-10-10T13:12:11.8383771Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).Run.func1()
2023-10-10T13:12:11.8384749Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:218 +0x91
2023-10-10T13:12:11.8385124Z
2023-10-10T13:12:11.8385424Z Goroutine 131 (running) created at:
2023-10-10T13:12:11.8385959Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).Run()
2023-10-10T13:12:11.8386750Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:216 +0x624
2023-10-10T13:12:11.8387409Z github.com/ovn-org/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller.(*Node).Run.func1()
2023-10-10T13:12:11.8388248Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller/node.go:169 +0xea
2023-10-10T13:12:11.8388529Z
2023-10-10T13:12:11.8388665Z Goroutine 124 (running) created at:
2023-10-10T13:12:11.8389201Z github.com/ovn-org/ovn-kubernetes/go-controller/pkg/informer.(*eventHandler).Run()
2023-10-10T13:12:11.8390049Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/pkg/informer/informer.go:216 +0x624
2023-10-10T13:12:11.8390690Z github.com/ovn-org/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller.(*Node).Run.func1()
2023-10-10T13:12:11.8391543Z /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/hybrid-overlay/pkg/controller/node.go:169 +0xea
2023-10-10T13:12:11.8391905Z ==================
2023-10-10T13:12:11.8392427Z I1010 13:12:11.833678 26777 ovn_node_linux.go:246] Add hybridOverlay Node remoteNode
2023-10-10T13:12:11.8392956Z I1010 13:12:11.834277 26777 informer.go:319] Successfully synced 'remoteNode'
2023-10-10T13:12:11.8397498Z I1010 13:12:11.835199 26777 ovs.go:168] Exec(14): stderr: ""
2023-10-10T13:12:11.8398988Z I1010 13:12:11.835328 26777 ovs.go:164] Exec(15): /fake-bin/ovs-vsctl --timeout=15 --if-exists get interface br-ext mac_in_use
https://github.com/ovn-org/ovn-kubernetes/actions/runs/6469466485/job/17563581067?pr=3953
See on PR #3913