kubevirt, kind: Add a flag to install ipamclaims

ovn-org / ovn-kubernetes

A robust Kubernetes networking platform

https://ovn-kubernetes.io/

Apache License 2.0

767 stars 333 forks source link

kubevirt, kind: Add a flag to install ipamclaims #4426

Closed qinqon closed 3 weeks ago

qinqon commented 3 weeks ago

What this PR does and why is it needed

Using kind.sh to deploy a cluster with ovn-k + kubevirt at the ipamclaim controller project, we should skip installing the controller itself so it can be installed from the repo version. This change add a new knob to install the kubevirt ipamclaims controller and remove the installation done at the kubevirt flag.

Description for the changelog

Add --install-kv-ipamclaims flag to kind.sh

-->

Add --install-kv-ipamclaims flag to kind.sh

qinqon commented 3 weeks ago

I think that if what you really need is a way to choose which version is installed, then pass that, instead of a flag to install or not the same version.

Make sense

coveralls commented 3 weeks ago

Changes unknown when pulling cf40510e489eaf99a6c1656aaa74924da917730b on qinqon:kubevirt-kind-add-knob-for-ipamclaims into on ovn-org:master.