search

ovn-org / ovn-kubernetes

A robust Kubernetes networking platform
https://ovn-kubernetes.io/
Apache License 2.0
767 stars 333 forks source link

Fix registering northd metrics on appropriate nodes #4428

Closed jcaamano closed 4 days ago

jcaamano commented 3 weeks ago

With IC, we are not registering northd metrics since there is no ovnkube-master pod. To fix, use ovn-db-pod=true label instead since in all our deployment models northd has been collocated with the DBs.

coveralls commented 3 weeks ago

Coverage Status

coverage: 52.737% (-0.02%) from 52.757% when pulling af9ae2d2428bd2073ec784d0890282830d4f56ee on jcaamano:northd-metrics-fix into 16da3ced728dc9c4fbe6bdece7a6f37d4edf4d6e on ovn-org:master.

jcaamano commented 2 weeks ago

/lgtm

Can set approve once we rebase and/or figure out the failures.

rebased!

coveralls commented 2 weeks ago

Coverage Status

coverage: 52.705% (-0.02%) from 52.729% when pulling d8c924f33cbaa5a5a8c507c8b759c0209da88496 on jcaamano:northd-metrics-fix into 17dce5cc7a56cf9cb082b6ba44e8f69809b8763a on ovn-org:master.

jcaamano commented 2 weeks ago

existing flake

--- FAIL: TestNetworkPolicyV2Conformance/AdminNetworkPolicyEgressSCTP/Should_support_an_'deny-egress'_policy_for_SCTP_protocol;_ensure_rule_ordering_is_respected (3.17s)

https://github.com/ovn-org/ovn-kubernetes/issues/4142

new flake

[FAIL] External Gateway With Admin Policy Based External Route CRs e2e multiple external gateway validation Should validate ICMP connectivity to multiple external gateways for an ECMP scenario [It] IPV4

https://github.com/ovn-org/ovn-kubernetes/issues/4432

Rerunning