search

ovn-org / ovn-kubernetes

A robust Kubernetes networking platform
https://ovn-kubernetes.io/
Apache License 2.0
767 stars 333 forks source link

EgressIP support on user defined networks #4438

Open pperiyasamy opened 2 weeks ago

pperiyasamy commented 2 weeks ago

This commit adds an enhancement proposal to support EgressIP for the user defined segmentation networks which serves as a primary network for the pods.

coveralls commented 2 weeks ago

Coverage Status

coverage: 52.644% (-0.09%) from 52.729% when pulling dad57d386bc434ba0982a564aaba62667cde6f30 on pperiyasamy:okep-multi-network-egressip into 17dce5cc7a56cf9cb082b6ba44e8f69809b8763a on ovn-org:master.

martinkennelly commented 1 week ago

Partially reviewed - as discussed via slack - we need to rework this for non-IC where pkt marks wont survive when pkts cross nodes.

martinkennelly commented 1 week ago

can you do me a favour? Feel free to say no cause it maybe a pain in the head for you.. but itll be easier for everyone to inspect the new arch. If theres no changes for any of the following deployment mods + network, fine to combine them in the same file, but name the file appropriately.

I think we need diagrams for the following combinations for each EIP "config" (defined later):

primaryeip-cdn-ic

primaryeip-cdn-non-ic

primaryeip-udn-l3-ic

primaryeip-udn-l3-non-ic

primaryeip-udn-l2

secondaryeip-cdn-ic

secondaryeip-cdn-non-ic

secondaryeip-udn-l3-ic

secondaryeip-udn-l3-non-ic

secondaryeip-udn-l2

primary means EIP is assigned to a pkt egressing primary interface and secondary is egress-ing a host secondary interface.

EIP "configs":

two pods, EIP with one IP - one on a node and another on the egress node two pods, EIP with two IPs - one on a node and another on one of the egress nodes Name the files so its clear which deployment model + network(s) we are in.

Peri will update the info to incorporate: https://docs.google.com/document/d/1mlhI9TJgy7DxJT-JX7Qz9_-rTgivZwlO4Pfyob616cs/edit

tssurya commented 1 week ago

I have not looked at anything here in depth, but I want to say I'm loving what's happening here in this PR 👏👏👏👏👏

coveralls commented 1 week ago

Coverage Status

coverage: 52.745% (-0.002%) from 52.747% when pulling 9fb2ab63ab476ba31640b95bcea4da8f3fc77a11 on pperiyasamy:okep-multi-network-egressip into afd362fc240c75decc6b915ba3c211734afe541d on ovn-org:master.

coveralls commented 1 week ago

Coverage Status

coverage: 52.742% (-0.005%) from 52.747% when pulling 0ddb7500198bc6dbd72320eeaeea1c173fe6ee5f on pperiyasamy:okep-multi-network-egressip into afd362fc240c75decc6b915ba3c211734afe541d on ovn-org:master.

coveralls commented 1 week ago

Coverage Status

coverage: 52.745% (-0.002%) from 52.747% when pulling 40f831ea15b5213c748c7ecf4fe854308de62666 on pperiyasamy:okep-multi-network-egressip into afd362fc240c75decc6b915ba3c211734afe541d on ovn-org:master.