Avoid calling oc.deleteStaleNodeChassis for every node update event

ovn-org / ovn-kubernetes

A robust Kubernetes networking platform

https://ovn-kubernetes.io/

Apache License 2.0

767 stars 333 forks source link

Avoid calling oc.deleteStaleNodeChassis for every node update event #4439

Open winsopc opened 2 weeks ago

winsopc commented 2 weeks ago

In large scale zone around 800 nodes, this check consume more than 60% of the cpu time. we only need check when old and new node object has chassis id annotation change.

What this PR does and why is it needed

Which issue(s) this PR fixes

Fixes #

Special notes for reviewers

How to verify it

Details to documentation updates

Description for the changelog

Does this PR introduce a user-facing change?

winsopc commented 2 weeks ago

pprof:

winsopc commented 2 weeks ago

@cathy-zhou @trozet PTAL

coveralls commented 2 weeks ago

coverage: 52.71% (-0.02%) from 52.729% when pulling b11ce00973edd7899db9ee9e743527ce37c09904 on winsopc:fix-sb-chassis-check into 17dce5cc7a56cf9cb082b6ba44e8f69809b8763a on ovn-org:master.

coveralls commented 2 weeks ago

coverage: 52.719% (-0.01%) from 52.729% when pulling 6a4a55729b974d9b176ca395f6e0f5608cc2a6ed on winsopc:fix-sb-chassis-check into 17dce5cc7a56cf9cb082b6ba44e8f69809b8763a on ovn-org:master.