search

ovn-org / ovn-kubernetes

A robust Kubernetes networking platform
https://ovn-kubernetes.io/
Apache License 2.0
767 stars 333 forks source link

Add missing places when renaming ovn-kubernetes packages #4452

Closed flavio-fernandes closed 1 week ago

flavio-fernandes commented 1 week ago

In commit https://github.com/ovn-org/ovn-kubernetes/commit/fabb87bbc7f5a2036c55736b2dc025b0c60053c9, we renamed the packages, but missed a few important scripts and documentation.

Fixes: #4451

tssurya commented 1 week ago

oh shoot!!! nice catch @flavio-fernandes !! what a bad instance!! I had no idea we were using packages in this way... from our own CI.. ? https://ovn-kubernetes.io/ci/ci/ can you please add docs or add a section packages and add this information? its not intuitive that we had changed the package naming but this was not being enforced in so many places?

flavio-fernandes commented 1 week ago

the changes LGTM!

Could you please add docs to https://ovn-kubernetes.io/developer-guide/image-build/ ?

Add a section "Images/Packages" subsection(perhaps change main heading to OVN-Kubernetes Images - no need for container) and then add details on how each PR that is built is downloading these artifacts/packages that are hosted on github etc.. Mention these come from the two docker files and test.yml is where the workflow is kept etc etc With that we should be set and developers can know -> what are these packages? how are they built? how can they be used (etc they are also used in KIND scripts)?

NP. PTAL.

flavio-fernandes commented 1 week ago

existing flake

--- [FAIL] External Gateway With Admin Policy Based External Route CRs

https://github.com/ovn-org/ovn-kubernetes/issues/4142