search

ovn-org / ovn

Open Virtual Network
Apache License 2.0
497 stars 244 forks source link

Add time exceeded flow for fip #230

Open ts170710 opened 9 months ago

ts170710 commented 9 months ago

211 https://github.com/ovn-org/ovn/issues/211 Add "ip4.src == " to match for distinguish between external router gateway and floatingIP to handle time exceeded packet.

dceara commented 8 months ago

@ts170710 Thanks for your PR!

I guess I'm not sure I understand how this is supposed to be useful. We already have flows in IP_INPUT stage that check for ip.ttl == {0, 1} && !ip.later_frag packets and reply with Time Exceeded for those. Why isn't that enough?

@ts170710 just in case you missed my question above.

Thanks, Dumitru

ts170710 commented 7 months ago

@ts170710 Thanks for your PR! I guess I'm not sure I understand how this is supposed to be useful. We already have flows in IP_INPUT stage that check for ip.ttl == {0, 1} && !ip.later_frag packets and reply with Time Exceeded for those. Why isn't that enough?

@ts170710 just in case you missed my question above.

Thanks, Dumitru

@dceara Thank you for your comment! As described in #211, ip.ttl == {0, 1} treats floatingIPs and router gateway IPs together. When traceroute to cloud instances associated with the router, the router gateway IP address gets replaced by ip4.dst <-> ip4.src, resulting in the inability to display the router gateway IP address in the traceroute results.